Skip to content

fix installation crash from StaticBoxSizer changes#12199

Merged
seanbudd merged 19 commits intomasterfrom
fix-12198
Mar 23, 2021
Merged

fix installation crash from StaticBoxSizer changes#12199
seanbudd merged 19 commits intomasterfrom
fix-12198

Conversation

@seanbudd
Copy link
Copy Markdown
Member

@seanbudd seanbudd commented Mar 19, 2021

Link to issue number:

Closes #12196

Summary of the issue:

The standard installation process crashes with the following traceback, likely caused by #12181

ERROR - unhandled exception (11:07:36.839) - MainThread (19656):
Traceback (most recent call last):
  File "gui\__init__.pyc", line 831, in <lambda>
  File "gui\__init__.pyc", line 861, in onAction
  File "gui\__init__.pyc", line 370, in onInstallCommand
  File "gui\installerGui.pyc", line 328, in showInstallGui
  File "gui\installerGui.pyc", line 182, in __init__
AttributeError: 'BoxSizerHelper' object has no attribute 'GetStaticBox'
INFO - core.main (11:08:15.675) - MainThread (19656):
Exiting

Description of how this pull request fixes the issue:

Fix various crashing GUI bugs introduced to the installation process in #12181

Testing strategy:

Test installation process manually (with both a left-to-right and right-to-left system language)

  • normal install
  • portable install

System tests which test the ability to open and use the installation dialogs have been added for

  • normal install
  • portable install

Known issues with pull request:

None

Change log entry:

None, fixes new unreleased issue

Code Review Checklist:

  • Pull Request description is up to date.
  • Unit tests.
  • System (end to end) tests.
  • Manual tests.
  • User Documentation.
  • Change log entry.
  • Context sensitive help for GUI changes.

@AppVeyorBot

This comment has been minimized.

@seanbudd seanbudd marked this pull request as draft March 19, 2021 01:24
@AppVeyorBot

This comment has been minimized.

@AppVeyorBot

This comment has been minimized.

@AppVeyorBot

This comment has been minimized.

@AppVeyorBot

This comment has been minimized.

@AppVeyorBot

This comment has been minimized.

@AppVeyorBot

This comment has been minimized.

@seanbudd seanbudd marked this pull request as ready for review March 22, 2021 02:28
@seanbudd seanbudd requested a review from feerrenrut March 22, 2021 02:32
@seanbudd seanbudd self-assigned this Mar 22, 2021
@seanbudd seanbudd changed the title fix options convention from StaticBoxSizer changes fix installation crash from StaticBoxSizer changes Mar 22, 2021
@amirsol81
Copy link
Copy Markdown

Any chance of implementing this so that we can resume testing NVDA alphas? Installation still gets aborted even with the latest alpha.

@XLTechie
Copy link
Copy Markdown
Collaborator

XLTechie commented Mar 23, 2021 via email

@amirsol81
Copy link
Copy Markdown

@XLTechie You are right. Updating works whereas installing afresh doesn't. So I updated to Alpha 22057 successfully via NVDA's Check for Update facility.

@seanbudd
Copy link
Copy Markdown
Member Author

Any chance of implementing this so that we can resume testing NVDA alphas? Installation still gets aborted even with the latest alpha.

Running the exe with the --silent-install flag should also work with current alphas, even though it crashes on exit

Copy link
Copy Markdown
Contributor

@feerrenrut feerrenrut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @seanbudd 🎉

@seanbudd seanbudd merged commit 0316158 into master Mar 23, 2021
@seanbudd seanbudd deleted the fix-12198 branch March 23, 2021 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

NVDA Alpha 22012: installation aborts unexpectedly

5 participants