Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
7 tasks
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
seanbudd
commented
Mar 22, 2021
feerrenrut
suggested changes
Mar 22, 2021
|
Any chance of implementing this so that we can resume testing NVDA alphas? Installation still gets aborted even with the latest alpha. |
Collaborator
|
While it makes install testing an impossibility, can you not just install an
earlier alpha, and then update it in-place?
|
|
@XLTechie You are right. Updating works whereas installing afresh doesn't. So I updated to Alpha 22057 successfully via NVDA's Check for Update facility. |
feerrenrut
reviewed
Mar 23, 2021
Member
Author
Running the exe with the |
feerrenrut
approved these changes
Mar 23, 2021
Contributor
feerrenrut
left a comment
There was a problem hiding this comment.
Looks good @seanbudd 🎉
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Closes #12196
Summary of the issue:
The standard installation process crashes with the following traceback, likely caused by #12181
Description of how this pull request fixes the issue:
Fix various crashing GUI bugs introduced to the installation process in #12181
Testing strategy:
Test installation process manually (with both a left-to-right and right-to-left system language)
System tests which test the ability to open and use the installation dialogs have been added for
Known issues with pull request:
None
Change log entry:
None, fixes new unreleased issue
Code Review Checklist: