don't rely on star imports from synthDriverHandler#12172
Merged
seanbudd merged 7 commits intoMar 17, 2021
Conversation
…remove unused imports
See test results for failed build of commit efca50c7f4 |
Member
|
I've added a changelog entry and tested this using a method similar to #12126, by checking if the functions that are exported from |
seanbudd
approved these changes
Mar 17, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
None
Summary of the issue:
Currently a few modules relies on star imports from
synthDriverHandlermaking it unnecessarily difficult to perform refactoring (I've stumbled on this when writing code for #12168)Description of how this pull request fixes the issue:
Now both
settingsDialogsandglobalCommandsare importing what they need explicitly.Testing strategy:
synthDriverHanderfrom synthDriver import *I've executed flake8 for the entire file and imported explicitly only whatever they were using.Known issues with pull request:
None known
Change log entry:
Code Review Checklist: