controlTypes: Remove deprecated ROLE_EQUATION#12164
Merged
Merged
Conversation
seanbudd
approved these changes
Mar 15, 2021
seanbudd
left a comment
Member
There was a problem hiding this comment.
LGTM, confirmed that there were no other usages
See test results for failed build of commit 78cbe4160c |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
None. Implements deprecation from 4fd4fb4
Summary of the issue:
ROLE_EQUATIONin controlTypes has been deprecated since 2015 in favor ofROLE_MATH. Since 2021.1 is a compatibility breaking release it makes sense to remove code kept for backward compatibility.Description of how this pull request fixes the issue:
ROLE_EQUATIONhas been removed.Testing strategy:
With git grep ensured that only occurrence of the
ROLE_EQUATIONhas been in the code removed as part of this pr.Known issues with pull request:
None known
Change log entry:
Changes for developers:
Code Review Checklist: