Fix-up of #11467 in symbol file#12017
Merged
Merged
Conversation
- deleted extra tab - removed duplicate symbol definition
Contributor
Author
|
Cc @Adriani90, (author of #11467, if you want to comment on the choices I have made between the duplicated lines. |
michaelDCurran
approved these changes
Feb 1, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preliminary note:
This PR is a fix-up of little errors in #11467.. It is not meant to discuss the choices made in #11467, e.g. symbol names or level. This should be discussed in a separate issue if needed.
Link to issue number:
Fix-up of #11467
Summary of the issue:
#11467 added some extra math symbols in symbol file. But some little errors were introduced:
WARNING - external:characterProcessing.SpeechSymbols.load (22:41:44.605) - MainThread (13136):Invalid line in file D:\Cyrille\Dev\GIT\nvda\source\locale\en\symbols.dic: ∁ complement of the set noneThis is due to an extra tab in the line defining "complement of the set" symbol.
⨯ times someand
⨯ set times none≙ coresponds to noneand
≙ estimates none∘ of someand
∘ ring Operator noneDescription of how this pull request fixes the issue:
Removed the line relative to set operator because this character is not explicitely defined as set operator in unicode; it is defined as "vector or cross product".
Note: an alternative might have been to delete this line since this character is defined in CLDR as "vector cross product"
Kept "estimates" that seems more precise and remains short.
Kept "ring operator" that seems more precise than "of"; set verbosity level to "None" as many specific math symbols that are usually not recognized by TTS. But I moved the line in the "Functions" section.
Note: personnally, I find "rign operator" too long anyway, this PR is not meant to discuss the choices made in Added some mathematical symbols #11467.
Testing performed:
Known issues with pull request:
None
Change log entry:
None (fix-up of alpha)