Skip to content

Fix-up of #11467 in symbol file#12017

Merged
michaelDCurran merged 1 commit into
nvaccess:masterfrom
CyrilleB79:symbolFixUp
Feb 1, 2021
Merged

Fix-up of #11467 in symbol file#12017
michaelDCurran merged 1 commit into
nvaccess:masterfrom
CyrilleB79:symbolFixUp

Conversation

@CyrilleB79

Copy link
Copy Markdown
Contributor

Preliminary note:

This PR is a fix-up of little errors in #11467.. It is not meant to discuss the choices made in #11467, e.g. symbol names or level. This should be discussed in a separate issue if needed.

Link to issue number:

Fix-up of #11467

Summary of the issue:

#11467 added some extra math symbols in symbol file. But some little errors were introduced:

  1. The following warning appears at NVDA startup:
    WARNING - external:characterProcessing.SpeechSymbols.load (22:41:44.605) - MainThread (13136):
    Invalid line in file D:\Cyrille\Dev\GIT\nvda\source\locale\en\symbols.dic: ∁ complement of the set none
    This is due to an extra tab in the line defining "complement of the set" symbol.
  2. Three duplicate symbol definition have been found:
    • Symbol 1:
      ⨯ times some
      and
      ⨯ set times none
    • Symbol 2:
      ≙ coresponds to none
      and
      ≙ estimates none
    • Symbol 3:
      ∘ of some
      and
      ∘ ring Operator none

Description of how this pull request fixes the issue:

  • Removed the extra tab
  • Symbol 1:
    Removed the line relative to set operator because this character is not explicitely defined as set operator in unicode; it is defined as "vector or cross product".
    Note: an alternative might have been to delete this line since this character is defined in CLDR as "vector cross product"
  • Symbol 2:
    Kept "estimates" that seems more precise and remains short.
  • Symbol 3:
    Kept "ring operator" that seems more precise than "of"; set verbosity level to "None" as many specific math symbols that are usually not recognized by TTS. But I moved the line in the "Functions" section.
    Note: personnally, I find "rign operator" too long anyway, this PR is not meant to discuss the choices made in Added some mathematical symbols #11467.

Testing performed:

  • Checked that the warning has disappeared
  • Checked the symbol announcements

Known issues with pull request:

None

Change log entry:

None (fix-up of alpha)

- deleted extra tab
- removed duplicate symbol definition
@CyrilleB79

Copy link
Copy Markdown
Contributor Author

Cc @Adriani90, (author of #11467, if you want to comment on the choices I have made between the duplicated lines.

@michaelDCurran michaelDCurran merged commit 90dd4e9 into nvaccess:master Feb 1, 2021
@nvaccessAuto nvaccessAuto added this to the 2021.1 milestone Feb 1, 2021
@CyrilleB79 CyrilleB79 deleted the symbolFixUp branch February 1, 2021 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants