Remove blank lines in browseable message#12005
Merged
Merged
Conversation
michaelDCurran
requested changes
Jan 20, 2021
Contributor
Author
|
@michaelDCurran, this PR is ready. I have addressed your comments and performed again the teste of the initial description of this PR. |
michaelDCurran
previously approved these changes
Jan 22, 2021
michaelDCurran
approved these changes
Jan 22, 2021
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #12004
Summary of the issue:
When reading a text in a browseable message (such as formatting information) line by line pressing down arrow, there is one blank line between each line of text.
Description of how this pull request fixes the issue:
innerHTMLattribute and notinnerTextanymore.<pre>tag and escaping<character.Testing performed:
Incidentally, this PR also fixes a visual issue in raw text browseable message containing lines longer than the window: moving the cursor on blank lines would pane the whole text to its right-most position, making the beginning of the lines disappear. This was visually strange. This is not the case anymore with this PR since the unexpected blank lines have been removed.
Known issues with pull request:
None.
Change log entry:
Bug fixes!
Formatting information and other browseable messages do not present unexpected blank lines anymore. (#12004)