Python Console: Fix handling of the tab key in the input pane (#11532)#11936
Merged
michaelDCurran merged 2 commits intoJan 21, 2021
Merged
Conversation
…ss#11532) * Support indenting with tabs when editing a non-empty input line * Support tab-completion in the middle of an input line
Contributor
Author
|
@XLTechie, could you please check if the try-build of this PR meets your expectations? |
* Consider selection start rather than cursor position (different if selection is anchored at start) * Replace selection upon successful completion
michaelDCurran
approved these changes
Jan 21, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #11532
Summary of the issue:
Currently, when editing a non-empty input line, NVDA's Python Console does not support inserting a tab at the beginning of the line for indentation.
It does not support either performing tab-completion anywhere but at the end of an input line: This is fine when typing a new line, but limiting when editing an existing one.
Description of how this pull request fixes the issue:
Testing performed:
Known issues with pull request:
Change log entry:
Section: Bug fixes
In the Python Console, inserting a tab for indentation at the beginning of a non-empty input line and performing tab-completion in the middle of an input line are now supported.