Skip to content

Fix-up of #10973: Fallback to POSITION_FIRST when reporting formatting info at caret to report in MS Excel#11914

Merged
michaelDCurran merged 2 commits into
nvaccess:masterfrom
lukaszgo1:excelCellsFormattingAtCaret
Dec 8, 2020
Merged

Fix-up of #10973: Fallback to POSITION_FIRST when reporting formatting info at caret to report in MS Excel#11914
michaelDCurran merged 2 commits into
nvaccess:masterfrom
lukaszgo1:excelCellsFormattingAtCaret

Conversation

@lukaszgo1

Copy link
Copy Markdown
Contributor

Link to issue number:

Discussion in #6479

Summary of the issue:

It is currently impossible to request formatting info for an Excel cell with NVDA+F.

Description of how this pull request fixes the issue:

NVDA+F now falls back to POSITION_FIRST if there is no caret.

Testing performed:

  • Ensured that NVDA+F reports formatting info for an Excel cell.
  • Ensured that 'No formatting information' is reported for cases in which there is none such as a 'browse' button in the run dialog.

Known issues with pull request:

None known

Change log entry:

Section: Bug fixes
It is now possible to report formatting information for the focused Excel cell using NVDA+F.

@michaelDCurran michaelDCurran merged commit 325be94 into nvaccess:master Dec 8, 2020
@nvaccessAuto nvaccessAuto added this to the 2020.4 milestone Dec 8, 2020
@lukaszgo1 lukaszgo1 deleted the excelCellsFormattingAtCaret branch December 8, 2020 10:43
@feerrenrut

Copy link
Copy Markdown
Contributor

Is it important that this is in 2020.4? As it currently stands it will not be, and the changelog needs adjustment.

@michaelDCurran michaelDCurran modified the milestones: 2020.4, 2021.1 Dec 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants