Fix-up of PR #8393: Fix broken support for container AutoPropertyObject#11835
Merged
Conversation
Contributor
|
I won't merge this until tomorrow, to allow others to review it if they wish. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fix-up of PR #8393
Summary of the issue:
As of PR #8393,
baseObjects.GetterandCachingGetternow include in their__get__method a boolean-coercion test on theAutoPropertyObjectinstance.This test, namely
if not instance, fails in its purpose if ever theAutoPropertyObjectdefines either a__len__or a__bool__method.Long story short, it has been the cause of a regression in WebAccess, where we historically used the
AutoPropertyObjectfacility on objects that are also containers.Description of how this pull request fixes the issue:
Change the boolean-coercion test into a test for nullity:
if instance is None.Testing performed:
Known issues with pull request:
Change log entry:
I don't think this deserves a change log entry.