Skip to content

Add a specific debug channel for frequent synthDriver log messages#11816

Merged
michaelDCurran merged 1 commit into
nvaccess:masterfrom
CyrilleB79:filterSynthDebugMsgs
Nov 9, 2020
Merged

Add a specific debug channel for frequent synthDriver log messages#11816
michaelDCurran merged 1 commit into
nvaccess:masterfrom
CyrilleB79:filterSynthDebugMsgs

Conversation

@CyrilleB79

Copy link
Copy Markdown
Contributor

Link to issue number:

Fixes #11574

Summary of the issue:

When merging #11582 the nvwave debug log messages have been isolated in a specific 'nvwave' debug log category (in advanced settings panel).
However the frequent debug messages of OneCore driver are still logged at debug level and are really frequent, which makes debugging something else difficult.

Description of how this pull request fixes the issue:

  • As discussed in Log too verbose with last alpha #11574, I have isolated the OneCore debug log messages in their own 'synthDriver' log category.
  • I have put the isDebugForSynthDriver function in the synthDriverHandler.py file so that it may be used by other synth drivers as well.
  • For now, only OneCore has filtered debug messages. The only other synth that has debug messages is sapi5; however the message is not frequent at all (only at initialization), so I did not put it in the synthDriver log channel.

Testing performed:

Used OneCore with the synthDriver log category enabled or disabled. And checked that the messages are logged or not respectively. The only message that I have not been able to check is "Cancelled, stopped pushing audio".

Known issues with pull request:

None

Change log entry:

Since #11582 did not specify a change log, I would not add it here either.

@CyrilleB79 CyrilleB79 force-pushed the filterSynthDebugMsgs branch from ce275d3 to 36ad131 Compare November 8, 2020 21:11
@michaelDCurran michaelDCurran merged commit 6668e22 into nvaccess:master Nov 9, 2020
@nvaccessAuto nvaccessAuto added this to the 2020.4 milestone Nov 9, 2020
@CyrilleB79 CyrilleB79 deleted the filterSynthDebugMsgs branch November 11, 2020 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Log too verbose with last alpha

3 participants