Add a specific debug channel for frequent synthDriver log messages#11816
Merged
Conversation
ce275d3 to
36ad131
Compare
michaelDCurran
approved these changes
Nov 9, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #11574
Summary of the issue:
When merging #11582 the nvwave debug log messages have been isolated in a specific 'nvwave' debug log category (in advanced settings panel).
However the frequent debug messages of OneCore driver are still logged at debug level and are really frequent, which makes debugging something else difficult.
Description of how this pull request fixes the issue:
Testing performed:
Used OneCore with the synthDriver log category enabled or disabled. And checked that the messages are logged or not respectively. The only message that I have not been able to check is "Cancelled, stopped pushing audio".
Known issues with pull request:
None
Change log entry:
Since #11582 did not specify a change log, I would not add it here either.