Restore the ability to report Emphasis formatting#11813
Merged
Conversation
See test results for failed build of commit 36cc1f9503 |
See test results for failed build of commit 86346a48aa |
michaelDCurran
approved these changes
Nov 6, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #11808
Closes #11640
Fix-up of #11436
Summary of the issue:
When #11436 was merged, the check of formatConfig["reportEmphasis"] in getFormatFieldSpeech (speech_init_.py) was dropped. Thus the Emphasis checkbox in doc formatting settings did not control anything more and reporting of emphasised and strong formatting were controlled by 'Marked' checkbox state.
This was clearly not the intent of this PR if you read the first point of "Known issues" paragraph in the initial description.
Description of how this pull request fixes the issue:
Restored the dropped code line.
Testing performed:
It was tested on this document.
Known issues with pull request:
Emphasis or strong, reported when respectively or tags are encountered, are only reported in Internet Explorer. This seemed however to be already the case also before the regression, i.e. in NVDA 2020.2.
Change log entry:
Section: Bug fixes
Restored the ability to report Emphase formatting. (#11808, #11640)Cc @michaelDCurran to confirm this PR conforms to his initial intention.