pr11650 with fix for addon paths#11707
Merged
Merged
Conversation
… made absolute as soon as possible to protect against the current directory changing later on. Also store NVDA's app dir in globalVars.
…ars.appDir calls.
…n places where we can't be completely sure the path is absolute.
…in NVDAHelper and nvda_slave when loading NvDAHelperRemote.
…g them to stop an infinite while loop introduced in #11650
Member
Author
|
for those reviewing, only commit 2ae3811 is new. |
Member
Author
|
I can successfully run this commit with NVDARemote. But I would welcome testing by others. |
josephsl
approved these changes
Sep 30, 2020
josephsl
left a comment
Contributor
There was a problem hiding this comment.
At least add-ons are working.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a replacement of pr #11650 containing all original commits, but with one extra commit that stops an infinite while loop in addonHandler.getCodeAddon when loading an addon that has translations (such as nvdaRemote).