Revert PR #11586#11701
Merged
Merged
Conversation
Contributor
Could you please explain what synthesizers are negatively affected by this change and what are the negative effects? Having this documented may help people when making changes for SAPI5 driver in the future. |
michaelDCurran
approved these changes
Sep 29, 2020
Contributor
Author
|
Hi @lukaszgo1, this stops Say-all while in browse mode while using the cereProc SAPI5 synth. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
PR #11586
Summary of the issue:
PR #11586 introduced this change to address a long standing regression for Ivona synthesizers (since NVDA 2019.3). However, this then causes a regression in some other synthesizers, and this issue already has a more robust fix in alpha builds.
Description of how this pull request fixes the issue:
Revert this change, restoring behavior for CereProc voices
Testing performed:
None
Known issues with pull request:
Ivona synths will lose some information as per #11586
Change log entry:
None