WinVersion: add support for Windows 10 October 2020 Update (Version 20H2/2009)#11666
Merged
Conversation
…0H2/build 19042). Although it will be marketed as Version 20H2, release ID is still '2009'. Unless this changes next year, 2009 will be used to refer to 20H2.
codeofdusk
approved these changes
Sep 25, 2020
codeofdusk
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me!
- Is there a new Windows SDK to merge (like #10922)?
- Maybe
isWin10could map xxh1 to xx03 and xxh2 to xx09?
Contributor
Author
|
Hi, no SDK at the moment, and I expect none as 19042 is 19041 with an enablement package. I think it might not make sense to define “H1” and “H2” as “03” and “09”, respectively because we already have a version that broke that expectation (Version 2004/20H1), along with uncertainty over whether or not Microsoft will opt for one feature update or two next year (next year’s feature update will be a long-term support version, by the way). Thanks.
|
Contributor
|
It would be helpful if this (and similar PRs in the future) include a link to an official source to verify this is the appropriate build number. |
Contributor
Author
|
Hi, for reference (for anyone planning to post similar PR’s in the future), please post a link to WIP release preview channel announcements (a link will be provided below). Thanks.
|
Contributor
Author
|
Hi, As requested by Reef, official reference for 20H2: Thanks. |
Contributor
|
Thanks for adding the link @josephsl |
Contributor
|
As for:
I'd suggest making the keys for def isWin10(version: int = 1507, atLeast: bool = True):def isWin10(version: Union[int, string] = 1507, atLeast: bool = True):
if isinstance(version, int):
version = str(version)
assert isinstance(version, str)Though this should be done in a subsequent PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
None
Summary of the issue:
Let's NVDA detect build 19042 as Windows 10 Version 20H2/2009 (October 2020 Update). Note that release Id of 2009 is used for consistency with other Windows 10 version map until the spec is changed.
Description of how this pull request fixes the issue:
Adds "2009" entry to Windows 10 version map to record build 19042.
Testing performed:
Tested to make sure Version 20H2 is properly detected (source code copy).
Known issues with pull request:
None
Change log entry:
None
Additionao context:
October 2020 Update is May 2020 Update (Version 2004/build 19041) with an enablement package. Also, at some point in the future, it would be handy to update Windows 10 version map spec to include string keys so versions such as 20H2 and such can be recorded easily.
Thanks.