Revert "Synthesizer dialog: ensure 'Microsoft Sound Mapper' is named#11616
Revert "Synthesizer dialog: ensure 'Microsoft Sound Mapper' is named#11616josephsl wants to merge 1 commit into
Conversation
…(PR nvaccess#11353)" This reverts commit 4eb6f52, as a summer cumulative update for Windows 10 Version 2004 (and 20H2) fixed it.
|
Hi, Two things:
Thanks. |
|
Hi, Note that in some cases, "Microsoft Sound Mapper" isn't localized in Windows, but at least the fact that the label for it is back shows the fundamental issue was solved. Thanks. |
|
As @josephsl pointed out above even though "Microsoft Sound Mapper" is once again named its name is not translated even for locales for which its name was translated for earlier Windows versions. From the end user perspective this is a regression. How about changing this PR such that if the first entry in the devices list is either empty or "Microsoft Sound Mapper" the translated name is used? |
I think this makes sense, there may also be users who haven't yet updated windows to the fixed version. |
|
Hi, I think that change would mean this PR will be closed, as it becomes a tweak, not a reversion as envisioned. Another option is forcefully do a tweak (and commit) from the repo rather than doing a straight reversion. Note that Microsoft Sound Mapper is translated correctly in dev channel builds, so it is not strictly a regression from NVDA side. Thanks.
|
|
Closed with the merge of #11627 to beta. |
Link to issue number:
Reverts #11353
Original issue: #11349
Summary of the issue:
In earlier releases of Windows 10 Version 2004 (May 2020 Update), Microsoft Sound Mapper was not named (empty string). IN a summer cumulative update for 2004 (and 20H2), this problem is gone.
Description of how this pull request fixes the issue:
Reverts PR #11353 via beta branch.
Testing performed:
Tested via source and from Python Console (in 2020.2 and 2020.3 beta) to make sure Microsoft Sound Mapper is listed (tested on both 2004 and 20H2).
Known issues with pull request:
None
Change log entry:
None (#11349 entry removed as part of this PR).
Thanks.