Fix-up of PR #11582: filter an extra call to log.debug in nvwave channel#11614
Merged
Conversation
Contributor
Author
|
@feerrenrut, this is ready for review. |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
None
Fix-up of #11582.
Summary of the issue:
When #11582 was implemented, I have forgotten to filter a call to log.debug under nvwave channel in nvwave.py. Thus the following message appears regularly in the log even if nvwave debug logging option is not enabled in Advanced settings panel.
Description of how this pull request fixes the issue:
Filter this call to log.debug as for other already filtered calls.
So now, in nwave.py, all calls to log.debug are filtered under the nvwave debug log category except the following one:
As written in #11582, I have left this one outside of nvwave debug filter since it was an error and thus seemed more important to me. Let me know however if my reasoning is not correct since I do not know when this error can occur.
Moreover, the calls to log.debugWarning and log.warning are not filtered since they are not at debug level.
Testing performed:
Changed synthesizer and checked that this message has disappeared.
Known issues with pull request:
None.
Change log entry:
N/A