App modules: add commsapps app module for Windows 10 Mail and Calendar in order to restore browse mode functionality when reading emails#11608
Merged
Conversation
… 16005.13110 in order to restore browse mode functionality. Re nvaccess#11439. In 2020, as part of unifying Mail and Calendar, hxoutlook.exe was renamed to commsapps.exe. Without the new app module, browse mode in Mail will not function, therefore add an alias app module for hxoutlook.py.
michaelDCurran
previously approved these changes
Sep 29, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
Necessary foundation for #11440
Link to issue number:
Fixes #11439
Summary of the issue:
Browse mode is not engaged when trying to read emails in Windows 10 Mail version 16005.13110 and later.
Description of how this pull request fixes the issue:
Adds a dedicated alias app module named "commsapps" that will inherit everything from hxoutlook app module (older executable file name for Mail), which in turn will be powered by hxmail app module.
Testing performed:
Tested via Windows 10 App Essentials and with source copy to make sure that browse mode is engaged when reading emails (success reported by users).
Known issues with pull request:
None
Change log entry:
Bug fixes:
It is again possible to use browse mode when reading emails in Windows 10 Mail 16005.13110 and later. (#11439)
Additional context:
This PR is required to remove now obsolete hxmail app module (see #11440 for rationale). For this reason, commsapps is an alias of hxoutlook, not hxmail.
Thanks.