Chrome: Don't announce 'list' on every line of ul, dl and ol tags in contenteditables#11605
Merged
Conversation
…at 'list' is not announced on every line when in a contenteditable.
See test results for failed build of commit 7da2b4ebb1 |
LeonarddeR
reviewed
Sep 15, 2020
| ) | ||
| # Tab into the contenteditable - focus mode will be enabled. | ||
| spy.emulateKeyPress("tab") | ||
| # DownArow into the list. 'list' should be announced when entering. |
Collaborator
There was a problem hiding this comment.
Typo
Suggested change
| # DownArow into the list. 'list' should be announced when entering. | |
| # DownArrow into the list. 'list' should be announced when entering. | |
feerrenrut
suggested changes
Sep 15, 2020
…rather than buttons. They no longer need to be focusable as we use f6 not tab.
…ion, which then means that switching between browse and focus modes produces a spoken string we can check for.
…sure we don't accidentally test in browse mode.
See test results for failed build of commit 771e37bc79 |
feerrenrut
previously approved these changes
Sep 16, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #7562
Summary of the issue:
When arrowing up and down a ul, dl or ol list in Google Chrome, 'list' is announced on every line, and no announcement is made when leaving the list.
This can be reproduced when reading through a list in a Google Docs document in Chrome.
Or by the following test case in Chrome:
This is because NVDA treats interactive and presentational lists differently. Interactive lists (such as
<select>of size greater 1 and ARIA list boxes) it assumes only one line (value) is rendered, and thus it announces list on the line. But for presentational lists (ul,dlandoltags), it announces list at the start, and out of list at the end.NVDA normally detects presentation lists from interactive lists by the readonly state. Presentation lists have this, interactive lists don't.
However, if a presentation list is within a
contenteditable, Chrome seems to remove the readonly state. Note that Mozilla Firefox does not remove it and thus does not reproduce the issue.There was a request for this to be fixed on the Chrome side, but as this is taking a long time and the change in NVDA is small, we should do it here also.
Description of how this pull request fixes the issue:
Adds a new PresentationList NVDAObject class to Chrome IAccessibles for
ul,dlandOLtags, and forces thereadonlystate.Testing performed:
<select>tag of size 2 in Chrome in browse mode and confirmed that it is still announced as an interactive list.Known issues with pull request:
None.
Change log entry:
Bug fixes: