Announce entering a listItem when moving by character or word in contentEditables and browse mode #11569
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
LeonarddeR
previously approved these changes
Sep 7, 2020
488a514 to
8f4cdd8
Compare
This comment has been minimized.
This comment has been minimized.
Member
Author
|
This pr now depends on pr #11581. |
feerrenrut
reviewed
Sep 10, 2020
… text. this includes contentEditables and browse mode.
…e. actually uses contentEditable in focus mode, and also tests moving by word.
99032a0 to
8ae26e1
Compare
This comment has been minimized.
This comment has been minimized.
Member
Author
|
@feerrenrut I have improved the test so that it actually uses a contentEditable in focus mode, and also tests moving by word (as its name suggests it should). |
feerrenrut
previously approved these changes
Sep 15, 2020
Comment on lines
+58
to
+61
| # Move focus into the content editable. | ||
| # This will turn on focus mode. | ||
| # And the caret will be on the paragraph before the list. | ||
| spy.emulateKeyPress("tab") |
Contributor
There was a problem hiding this comment.
I wonder if we should use the option to speak focus/browse mode and check for it here?
| _asserts.strings_match( | ||
| actualSpeech, | ||
| "list item level 1 \nz" | ||
| "list item level 1 \nb" |
Contributor
There was a problem hiding this comment.
It would be good if we could make this easier to read. I assume that the new line was added to separate utterances.
Would it be more clear if written like this?
Suggested change
| "list item level 1 \nb" | |
| "\n".join([ | |
| "list item level 1 ", | |
| "b" | |
| ]) |
Member
Author
|
@feerrenrut hopefully one last review please. Focus mode is now forced. And I have taken your suggestion of in the string assertion. |
feerrenrut
approved these changes
Sep 16, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
None.
Summary of the issue:
When inside a list in a contentEditable on the web, cursoring from one listItem to the next does not provide any speech feedback telling you that you are in a new listItem. In browse mode, at least you'd probably have a bullet or number which would alert you to the fact, but in contentEditables, usually the cursor skips over the bullet.
Take this example in Chrome / Firefox.
NVDa should speak "list item" when cursoring with left and right arrow from the first to the second, or the second to the first. Note that we should not do this when moving by line, nor should we say "out of list item" as that is somewhat redundant.
Description of how this pull request fixes the issue:
these changes together mean that NvDA will now announce 'listItem' when moving into a listItem when navigating by character or word.
Testing performed:
With the above testcase in Firefox / chrome: in focus mode ensured that pressing left and right arrow crossing the list item boundary speaks "list item" but not "out of list item" and ensure that moving by line does not announce "list item".
Known issues with pull request:
When arroing into a list from the outside with the left or right arrows, NVDA will say "list list item". Technically this is correct, but perhaps a little redundant. However, as this only happens when moving by word or character, I don't believe this is too annoying, weighing it up against what this does fix.
Change log entry:
Bug fixes: