Fix-up of PR 9724. Stop including empty properties when copying object to the clipboard#11441
Merged
Conversation
LeonarddeR
previously approved these changes
Jul 31, 2020
michaelDCurran
previously approved these changes
Aug 3, 2020
ea31636
michaelDCurran
approved these changes
Aug 3, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #11438
Summary of the issue:
When converting script navigatorObject_current to Python 3 (see #9724) the fact that only non-empty properties should be presented to the user has been missed. For users this meant that trailing spaces which aren't part of the control were added when joining properties together,.
Description of how this pull request fixes the issue:
Only non-empty strings are considered when creating string presented to the user.
Testing performed:
Copied name of the folder in Windows Explorer with NVDA _ num5 ensured that there is no spurious trailing space at the end whereas with the current master it is added.
Known issues with pull request:
None
Change log entry:
Section: Bug fixes
NVDA no longer appends nonexistent trailing space when copying current navigator object to the clipboard.