GUI: Do not scale the default size of -1 (#10216)#11424
Merged
feerrenrut merged 1 commit intoJul 27, 2020
Conversation
feerrenrut
approved these changes
Jul 27, 2020
feerrenrut
left a comment
Contributor
There was a problem hiding this comment.
Thanks @JulienCochuyt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #10216
Summary of the issue:
On the Symbol Pronunciation dialog, depending on the display scaling settings, the Filter edit field and the Replacement edit field might be functional but not visible.
Description of how this pull request fixes the issue:
Do not attempt to scale the default size of -1.
That is, replace
self.scaleSize((300, 1))by(self.scaleSize(300), -1)Testing performed:
Ensured that both fields are visible with varying display scaling settings.
Known issues with pull request:
Change log entry:
I don't think this deserves a change log entry.