Flake8: Also check *.pyw and sconscript (#11097)#11099
Merged
feerrenrut merged 2 commits intonvaccess:masterfrom May 4, 2020
Merged
Flake8: Also check *.pyw and sconscript (#11097)#11099feerrenrut merged 2 commits intonvaccess:masterfrom
*.pyw and sconscript (#11097)#11099feerrenrut merged 2 commits intonvaccess:masterfrom
Conversation
Contributor
|
What about sconstruct, and sconscripts such as cldrDict_sconscript? |
Contributor
Author
|
@lukaszgo1 wrote:
Good catch. Thanks for pointing it out. Changed "sconscript" to "*sconscript" and added "sconstruct".
|
LeonarddeR
approved these changes
May 4, 2020
feerrenrut
approved these changes
May 4, 2020
Contributor
feerrenrut
left a comment
There was a problem hiding this comment.
Thanks @JulienCochuyt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #11097
Summary of the issue:
Flake8 checks currently ignore linting errors introduced in
nvda.pyworsconscriptfiles.Description of how this pull request fixes the issue:
Added
*.pywandsconscriptto the list of glob patterns to include for checks.Testing performed:
Ensured linting errors introduced in
nvda.pywandsconscriptfiles are reported.Ensured linting errors introduced in a
.pyfile are still reported.Known issues with pull request:
Change log entry:
I don't think this deserves a change log entry.