Rewording in Input Gestures#10877
Conversation
See test results for failed build of commit 67c8e128b2 |
|
@ehollig When modifying scripts it is a good practice to convert them to script decorator. |
|
Hi, I think it might be helpful to put a source code level comment in there so we can investigate this further in coming weeks. Thanks.
|
|
While commend at the top of globalCommands would be helpful indeed, it should also be added to the contributing page on the wiki IMO. |
|
@ehollig Are you planning to work further on this one? |
|
I would like to work further on this one, however I am not sure how to proceed or why AppVeyorBot failed. |
|
Hi, After merging latest master, you must do the following in order: scons source (optional but highly recommended) For the latter two, read the output carefully and fix issues. Run the item again until no errors are found, then move onto the next item. Thanks. |
feerrenrut
left a comment
There was a problem hiding this comment.
I'll look at fixing the appveyor build failure.
Link to issue number:
Fixes #10814
Fixes #10301
Summary of the issue:
Someone searching input gestures for "reset configuration" would not find the keystroke for resetting configuration in NVDA's input gestures dialog because the word reset is not used in the description.
Also, the shortcut key NVDA+B (speakForeground), in the input gestures dialog has a description that does not align with the user guide. Someone searching for this script using keywords that is present in the user guide will not be able to find this keystroke.
Description of how this pull request fixes the issue:
Update the word reset in the input gestures dialog for the reset configuration script so it now says:
Pressing three times resets to factory defaults
Also updated the script description for speakForeground so it aligns with the user guide and now says:
Reads all controls in the active window
Testing performed:
Known issues with pull request:
None known
Change log entry:
A few scripts have been clarified in the input gestures dialog