Fix-up of: Browse mode: When the user moves the cursor, speak before setting selection. (PR #10389)#10458
Merged
Conversation
…setting selection. (PR nvaccess#10389)
Contributor
|
Ah. I didn't think of Elements List. This makes sense. However, it should be tested with the test case from #8831; i.e.
Press control+home, open elements list, select form fields, choose the input edit and press enter. I confirmed that without this patch, it says "a button". It should say "input edit" with the correct patch. |
michaelDCurran
approved these changes
Nov 10, 2019
Member
|
I confirmed this pr fixes the issue with the test from @jcsteh. |
This comment was marked as spam.
This comment was marked as spam.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fix-up of PR #10389
Summary of the issue:
PR #10389 reports before moving in
BrowseModeTreeInterceptor._quickNavScriptbut misses to do the same inElementsListDialog.onAction. I guess the same conditions apply there.@jcsteh can you please confirm?
Description of how this pull request fixes the issue:
Apply the same change in
ElementsListDialog.onActionto also cover moves made from the Elements List dialog.Testing performed:
Tested from source with Firefox and MS Word as part of my work on PR #10454.
Known issues with pull request:
Change log entry:
N/A