Fix-up of: "Add support for IA2_ROLE_LANDMARK #10110"#10444
Closed
LeonarddeR wants to merge 6 commits into
Closed
Conversation
added 4 commits
October 30, 2019 07:58
…LANDMARK in aria.ariaRolesToNVDARoles
Collaborator
Author
|
Some additional thoughts coming to mind here. Regions are very similar to groupings in that we only want them reported if they have a name. The aria module has the following comment:
With the grouping support about to be added, I wonder whether we should consider decoupling region reporting from landmarks. It has the following benefits:
@michaelDCurran If you agree with this approach, I think I prefer merging #10425 into this. |
Member
|
If it makes the code easier and more understandable for regions to be
separate from landmarks, that sounds good to me. However, note that for
labeled regions at least, move to next/previous landmark currently finds
them.
|
Collaborator
Author
|
Superseded by #10462 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes issues introduced by #10110
Summary of the issue:
The following issues arose after merging #10110
Description of how this pull request fixes the issue:
Testing performed:
Tested the following example:
data:text/html, <p>paragraph</p><div role="region">Region without label</div><div role="region" aria-label="this is a label">Region with a label</div><div role="main">This is a main landmark</div><article>This is an article</article><p>This is a paragraph, again</p>I've only been able to do it in Firefox yet.
Known issues with pull request:
We now announce end of article, we don't announce end of landmark. DO we agree this is OK?
Change log entry:
None