Fix-up of: "Compile NVDA with the Windows 10 SDK (#7568)"#10298
Merged
Conversation
michaelDCurran
approved these changes
Sep 30, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
None
Summary of the issue:
When NVDA still supported versions of Windows older than Windows 7 it was necessary to build it with Windows SDK 7.1A. This required special tool for SCons. In #7568 the tool itself was removed, however it was still imported in default sconscript for NVDAHelper.
Description of how this pull request fixes the issue:
The import is removed.
Testing performed:
Created a launcher from a clean repo with this change, ensured that launcher still works.
Known issues with pull request:
None known
Change log entry:
None needed.