Fix up of: Fix gui alignment issues (#6287) - addItem keywords#10205
Merged
michaelDCurran merged 1 commit intoSep 13, 2019
Conversation
michaelDCurran
approved these changes
Sep 13, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fix up of PR #6287
Summary of the issue:
The docstring for
BoxSizerHelper.addItemclaims to pass its keywords arguments to thewx.Sizer.Addmethod.The current implementation as of 87ed4d1 fails to do so.
When it has to force a particular flag - which is fine - it also overrides any other flag intentionally passed by the caller - which is not.
Description of how this pull request fixes the issue:
Amend flags instead of overriding them.
Testing performed:
Known issues with pull request:
Change log entry:
I do not think this deserves to be announced.