Fix up of: Launcher: Default to replacing an already running NVDA (#8320, #9827, #10179)#10183
Merged
michaelDCurran merged 1 commit intoSep 10, 2019
Conversation
LeonarddeR
approved these changes
Sep 10, 2019
|
Does this work on Windows 7 etc as well?
Brian
bglists@blueyonder.co.uk
Sent via blueyonder.
Please address personal E-mail to:-
briang1@blueyonder.co.uk, putting 'Brian Gaff'
in the display name field.
Newsgroup monitored: alt.comp.blind-users
-----
|
Contributor
Author
It should, as both processes (Windows pre and post 8.1) do add the |
michaelDCurran
approved these changes
Sep 10, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #10179
Fix up of #9827
Summary of the issue:
Regression introduced in #9827: in installed copy of NVDA, whenever one exits secure screens, NVDA restarts.
Description of how this pull request fixes the issue:
Do not automatically replace an existing instance of NVDA if the
--ease-of-accesscommand line parameter is provided.Testing performed:
Tested with Windows 10 64 bits version 1903.
I could reproduce the faulty behavior reported by @josephsl in #10179 by installing alpha build 18574.
I do not reproduce anymore with the try build 18579 for this PR.
Known issues with pull request:
Change log entry:
N/A