Fix up of: Abstract vision framework with included support for focus, navigator object and browse mode caret highlighting (PR #9064)#10160
Merged
Conversation
… navigator object and browse mode caret highlighting (PR nvaccess#9064)
LeonarddeR
approved these changes
Sep 2, 2019
LeonarddeR
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for catching this @JulienCochuyt!
Contributor
Author
You're welcome. You actually pointed me there with your useful pre-PR comments for my work on #3304. |
michaelDCurran
approved these changes
Sep 3, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fix up of PR #9064
Summary of the issue:
Commit 5ad32bf contains a small typo in
VisionHandler.handleConfigProfileSwitch: A local variable is namedrovidersToInitializewhile it seems obvious the intention was to name itprovidersToInitialize.Description of how this pull request fixes the issue:
Rename the local variable.
Testing performed:
None
Known issues with pull request:
Change log entry:
N/A