Add reference to visual studio code project repository#10064
Merged
Conversation
Collaborator
Author
|
@bramd: could you also have a look? |
Member
|
@LeonarddeR err... it looks like the submodule was not actually added? the only two files changed in this pr are readme.md and .gitignore. |
Collaborator
Author
|
@michaelDCurran: I'm sorry, I noticed that the description of the pr referenced the old situation where we used a submodule. @feerrenrut pointed out that it might be better to use a system where one has to check out the repository manually. See nvaccess/vscode-nvda#1 |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Depends on nvaccess/vscode-nvda#1
Closes #9971
Summary of the issue:
Visual Studio Code is currently well known for its accessibility and ease of use. Especially since the NVDA repository has a linting configuration built in, using Visual Studio Code's linter support is pretty handy for non visually working programmers.
Description of how this pull request fixes the issue:
Added a reference in the readme to a preconfigured VSCode workspace. This has to be checked out in the main source directory of NVDA.
.gitignoredeals with this.Several settings a configured in this project, see also nvaccess/vscode-nvda#1:
The current NVDA build environment is set up in such a way that it doesn't require a virtual Python environment.
This VSCode project does not define the python interrpetter setting by default.
Testing performed:
Tested that tests run from VS Code and that extra include directories are recognized.
Known issues with pull request:
None
Change log entry: