Skip to content

Python 3: Update py2exe to fix several issues#9856

Merged
feerrenrut merged 5 commits into
nvaccess:threshold_py3_stagingfrom
BabbageCom:py2exe_updates
Jul 3, 2019
Merged

Python 3: Update py2exe to fix several issues#9856
feerrenrut merged 5 commits into
nvaccess:threshold_py3_stagingfrom
BabbageCom:py2exe_updates

Conversation

@LeonarddeR

@LeonarddeR LeonarddeR commented Jul 2, 2019

Copy link
Copy Markdown
Collaborator

Link to issue number:

Fixes #9813
Closes #9841
Fixes #9831

Summary of the issue:

During development of the threshold_py3_staging branch, some issues have been identified in py2exe. They have either been merged into upstream or have been considered stable by us.

Description of how this pull request fixes the issue:

  1. importing _ssl will no longer raise a module not found error
  2. Trace backs now contain proper paths
  3. win32wnet and pywintypes are excluded at build time, as they are not necessary for a running copy of NVDA
  4. Traceback paths are no longer stripped when NVDA is frozen, as before (in master)
  5. Updated the readme, removing some outdated stuff as well and added a distinction between run time and build time dependencies.

Testing performed:

Made sure that the steps to reproduce revealed the expected behaviour.
I will also test the try build again when it is finished.

Known issues with pull request:

None

Change log entry:

None

@LeonarddeR LeonarddeR requested a review from feerrenrut July 2, 2019 13:37
feerrenrut
feerrenrut previously approved these changes Jul 2, 2019
View reviewed changes

@feerrenrut feerrenrut left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Leonard

@feerrenrut

feerrenrut commented Jul 2, 2019

Copy link
Copy Markdown
Contributor

Though this build is failing, it looks like there might be an issue with py2exe.

@feerrenrut feerrenrut dismissed their stale review July 2, 2019 14:03

Build is failing.

@LeonarddeR

LeonarddeR commented Jul 2, 2019

Copy link
Copy Markdown
Collaborator Author

Turns out I introduced this mistake after my last test of this, I know I'm bad, haha.
Fortunately, it was just a missing comma. Python is really weird in allowing concatenating strings "like " "this"

@LeonarddeR LeonarddeR requested a review from feerrenrut July 2, 2019 14:29
@feerrenrut feerrenrut merged commit 9812e7b into nvaccess:threshold_py3_staging Jul 3, 2019
@nvaccessAuto nvaccessAuto added this to the 2019.3 milestone Jul 3, 2019
@Adriani90 Adriani90 mentioned this pull request Jul 3, 2019
Closed
@josephsl josephsl mentioned this pull request Jul 23, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@feerrenrut feerrenrut feerrenrut approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

2019.3

Development

Successfully merging this pull request may close these issues.

3 participants

@LeonarddeR @feerrenrut @nvaccessAuto