Skip to content

Python 3: Update UIAutomationCore.dll comtypes module#9829

Merged
feerrenrut merged 1 commit into
nvaccess:threshold_py3_stagingfrom
BabbageCom:py3_UIA
Jul 3, 2019
Merged

Python 3: Update UIAutomationCore.dll comtypes module#9829
feerrenrut merged 1 commit into
nvaccess:threshold_py3_stagingfrom
BabbageCom:py3_UIA

Conversation

@LeonarddeR

Copy link
Copy Markdown
Collaborator

Link to issue number:

None

Description of this pull request

We bundle a comtypes wrapper for the UIAutomation dll as we want to make sure that everyone has the same wrapper that supports the most recent version of Windows. The current wrapper was build with an older version of comtypes on Python 2.

I ran comtypes.client.GetModule("UIAutomationCore.dll") from a Python 3.7.3 interpretter with comtypes 1.1.7. As always, the order of definitions in the file has changed drastically.

Testing performed:

Tested that NVDA still starts and has access to UIA

Known issues with pull request:

NOne

Change log entry:

None

@josephsl

josephsl commented Jun 27, 2019 via email

Copy link
Copy Markdown
Contributor

@LeonarddeR

Copy link
Copy Markdown
Collaborator Author

AH, that info is only in the commit it seems

  • File version: 7.2.18362.1
  • Product version: 10.0.18362.1

@josephsl

josephsl commented Jun 27, 2019 via email

Copy link
Copy Markdown
Contributor

@LeonarddeR LeonarddeR requested a review from feerrenrut July 1, 2019 11:26
@feerrenrut feerrenrut merged commit 5a0fb7f into nvaccess:threshold_py3_staging Jul 3, 2019
@nvaccessAuto nvaccessAuto added this to the 2019.3 milestone Jul 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants