New handy tech display models#9691
Merged
michaelDCurran merged 10 commits intoJun 21, 2019
Merged
Conversation
…eep mode functionality so that applications can signal to the driver that it temporarily close its ports.
Contributor
Author
|
Unfortunately I found an issue after opening this. Currently, when the driver is instantiated, it creates a hidden window to take messages from our proprietary apps, and when the driver is terminated or its constructor fails, that window is destroyed. However, I failed to take into account that instantiation of the driver may take place in a thread which is not in a position to handle window messages, and which is also different from the thread which will eventually attempt to destroy the window. In this scenario, which happens for automatic detection, we'll be left with a message window that not only won't handle messages but also won't go away when asked. And in fact this is what I'm seeing. |
Collaborator
|
I think this can easily be fixed by creating the window with
wx.CallAfter, which ensures that it is initiated on the main thread. You
can also destroy it that way.
Note that possible errors won't be caught and need to be logged that way.
|
… destroyed on the main ui thread.
Contributor
Author
|
@LeonarddeR thanks, that helped a lot. The problem went away for me, and I committed the change. |
Collaborator
|
Great! Could you also look at the huge diff? Git treats every single line of handyTech.py and bdDetect.py as changed, probably because the line endings have changed.
|
Contributor
Author
|
Any idea what I can use to track this down? I tried showing line endings in
Notepad++, which is what I'm using for Python right now, but it doesn't
show them.
Am Sa., 8. Juni 2019 um 17:03 Uhr schrieb Leonard de Ruijter <
notifications@github.com>:
… Great! Could you also look at the huge diff? Git treats every single line
of handyTech.py and bdDetect.py as changed, probably because the line
endings have changed.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#9691?email_source=notifications&email_token=AEKTKKEAFCP3TJMGMU73YO3PZPC3JA5CNFSM4HVXVKV2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXHWJPA#issuecomment-500131004>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AEKTKKDDTHAG47E5G76JMPLPZPC3JANCNFSM4HVXVKVQ>
.
|
Collaborator
|
In there, there is an option for line endings in the edit menu. I think they should be crlf.
|
Contributor
Author
|
I'm not seeing the forest for the trees.
Everything is using cr/lf and utf-8.
When I opened the pr I of course had to merge upstream beta to my branch.
There were but minor conflicts. Nothing that could explain a huge diff.
… |
Contributor
|
@FelixGruetzmacher I think NVDA stores just LF line endings in Git, since Git converts CRLF by default to LF on commit. This can be controlled in Gits config, see https://stackoverflow.com/questions/10418975/how-to-change-line-ending-settings for example. |
Contributor
Author
|
My core.autocrlf was true all the time, so any cr/lf on my machine would
have been converted to lf.
So now I have set core.autocrlf to false and I find that my files have lf
while upstream/beta has cr/lf.
Seems it's the other way round: NVDA has cr/lf by default, and my
autocrlf=true was the problem as it ate the cr.
However, here's a weird thing: When I git diff my working tree against
upstream/beta, the diff looks good, i.e. it only includes lines I actually
intended to change, but the lines I added all have a ^m at the end whereas
the unmodified lines around them don't. Has anyone seen this before? Is it
normal?
From the fact the diff is now down to a screenful, I would conclude my line
endings are now matching the convention. But if this is so, why then does
it say ^m in the plus lines but not in the surrounding ones?
Also, with autocrlf defaulting to true on Windows, why isn't this problem
popping up for many others?
What an unproductive phantom hunt if the vcs actually slows things down
rather than helping.
|
LeonarddeR
suggested changes
Jun 10, 2019
| className = u"Handy_Tech_Server" | ||
| def __init__(self, driver): | ||
| super(InvisibleDriverWindow, self).__init__(u"Handy Tech Server") | ||
| self.driver = driver |
Collaborator
There was a problem hiding this comment.
Please make this a weak reference. You can see how this works on the Model class.
There is also a possibility to provide a callback to the reference that is called when the reference dies, i.e. when the driver instance dies. We really need to make sure that the window is destroyed in that case. Could you also test this, e.g. by forcefully disconnecting a device and checking whether the window is destroyed correctly? I assume it will if terminate is called when the driver loses its connection.
| self.driver = driver | ||
| def windowProc(self, hwnd, msg, wParam, lParam): | ||
| if msg == window_message: | ||
| if wParam == 100 and lParam == 1: |
Collaborator
There was a problem hiding this comment.
Were do 100 and 1 stand for? Could you make these constants? Note that constants are capitalised.
| self.driver.go_to_sleep() | ||
| elif wParam == 100 and lParam == 0: | ||
| self.driver.wake_up() | ||
| return 0 |
Collaborator
There was a problem hiding this comment.
What does 0 mean in this context?
| self.driver.wake_up() | ||
| return 0 | ||
|
|
||
| window_message=windll.user32.RegisterWindowMessageW(u"Handy_Tech_Server") |
Collaborator
There was a problem hiding this comment.
This is now global to the driver module and therefore to NVDA as a whole. It would be nice if we could avoid this by registering the window message in create_message_window and unregister it in self.destroy_message_window
| try: | ||
| self._messageWindow.destroy() | ||
| except: | ||
| log.debugWarning("", exc_info=True) |
Collaborator
There was a problem hiding this comment.
Make sure that if you move window message registering to the driver, that it is properly unregistered.
LeonarddeR
suggested changes
Jun 11, 2019
LeonarddeR
left a comment
Collaborator
There was a problem hiding this comment.
Almost there. Thanks for the great work until now.
| time.sleep(self.timeout) | ||
| self._dev.close() | ||
| self._dev = None | ||
| time.sleep(self.timeout) # |
Collaborator
There was a problem hiding this comment.
There's an unnecessary hash after this line.
Contributor
Author
|
Thanks for your patience with me, and for the excellent and insightful
review!
Am Di., 11. Juni 2019 um 08:25 Uhr schrieb Leonard de Ruijter <
notifications@github.com>:
… ***@***.**** requested changes on this pull request.
Almost there. Thanks for the great work until now.
------------------------------
In source/brailleDisplayDrivers/handyTech.py
<#9691 (comment)>:
> raise RuntimeError("No Handy Tech display found")
+ def create_message_window(self):
+ try:
+ self._sleepcounter = 0
+ self._messageWindow = InvisibleDriverWindow(self)
+ except WindowsError:
+ log.debugWarning("", exc_info=True)
+ def destroy_message_window(self):
Please insert an empty line here.
------------------------------
In source/brailleDisplayDrivers/handyTech.py
<#9691 (comment)>:
> + except WindowsError:
+ log.debugWarning("", exc_info=True)
+ def destroy_message_window(self):
+ try:
+ self._messageWindow.destroy()
+ except WindowsError:
+ log.debugWarning("", exc_info=True)
+
+ def go_to_sleep(self):
+ self._sleepcounter += 1
+ if self._dev is not None:
+ # Must sleep before and after closing to ensure the device can be reconnected.
+ time.sleep(self.timeout)
+ self._dev.close()
+ self._dev = None
+ time.sleep(self.timeout) #
There's an unnecessary hash after this line.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#9691?email_source=notifications&email_token=AEKTKKB5PMWZ44HEIRY3JPLPZ5APBA5CNFSM4HVXVKV2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB3D3TFA#pullrequestreview-247970196>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AEKTKKDRMXQ4VULLBHNPFJTPZ5APBANCNFSM4HVXVKVQ>
.
|
LeonarddeR
reviewed
Jun 11, 2019
LeonarddeR
left a comment
Collaborator
There was a problem hiding this comment.
I'm sorry, I missed these imports, see below.
| Braille display driver for Handy Tech braille displays. | ||
| """ | ||
|
|
||
| import ui |
Collaborator
There was a problem hiding this comment.
This now seems duplicated
LeonarddeR
approved these changes
Jun 11, 2019
Collaborator
|
@michaelDCurran is there any way we could have this in 2019.2? |
Member
|
I'm rather reluctant to do this as it was not completed until after
beta1 was released. I feel it sets a bit of a bad trend.
However, I'd like @feerrenrut's opinion on this.
|
Contributor
|
Hi, to Michael and you
@LeonarddeR
I have a very bad opinion about it, because the translation strings freeze should be prolonged.
From: Leonard de Ruijter <notifications@github.com>
Sent: Monday, June 17, 2019 11:47 AM
To: nvaccess/nvda <nvda@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Subject: Re: [nvaccess/nvda] New handy tech display models (#9691)
@michaelDCurran <https://github.com/michaelDCurran> is there any way we could have this in 2019.2?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub <#9691?email_source=notifications&email_token=ACVCDE36YMP5XEGOPNCHN4DP25MTDA5CNFSM4HVXVKV2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODX2UQSQ#issuecomment-502614090> , or mute the thread <https://github.com/notifications/unsubscribe-auth/ACVCDEZR3UC3TFDPJHE7J4TP25MTDANCNFSM4HVXVKVQ> . <https://github.com/notifications/beacon/ACVCDE262FH4C4JPKY65XFLP25MTDA5CNFSM4HVXVKV2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODX2UQSQ.gif>
|
Contributor
|
Please see my previous comment mentioning leonards question
thx
From: Michael Curran <notifications@github.com>
Sent: Monday, June 17, 2019 11:55 AM
To: nvaccess/nvda <nvda@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Subject: Re: [nvaccess/nvda] New handy tech display models (#9691)
I'm rather reluctant to do this as it was not completed until after
beta1 was released. I feel it sets a bit of a bad trend.
However, I'd like @feerrenrut's opinion on this.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub <#9691?email_source=notifications&email_token=ACVCDE7SS7CZ3F7NWFKYU4LP25NPNA5CNFSM4HVXVKV2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODX2VEXQ#issuecomment-502616670> , or mute the thread <https://github.com/notifications/unsubscribe-auth/ACVCDE6Q6MPIRT532WOTTWLP25NPNANCNFSM4HVXVKVQ> . <https://github.com/notifications/beacon/ACVCDE7LVI2JWW6TVK7LSADP25NPNA5CNFSM4HVXVKV2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODX2VEXQ.gif>
|
Contributor
Author
|
There are no strings in the PR to which translation is applicable.
Am Mo., 17. Juni 2019 um 12:11 Uhr schrieb zstanecic <
notifications@github.com>:
… Please see my previous comment mentioning leonards question
thx
From: Michael Curran ***@***.***>
Sent: Monday, June 17, 2019 11:55 AM
To: nvaccess/nvda ***@***.***>
Cc: Subscribed ***@***.***>
Subject: Re: [nvaccess/nvda] New handy tech display models (#9691)
I'm rather reluctant to do this as it was not completed until after
beta1 was released. I feel it sets a bit of a bad trend.
However, I'd like @feerrenrut's opinion on this.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub <
#9691?email_source=notifications&email_token=ACVCDE7SS7CZ3F7NWFKYU4LP25NPNA5CNFSM4HVXVKV2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODX2VEXQ#issuecomment-502616670>
, or mute the thread <
https://github.com/notifications/unsubscribe-auth/ACVCDE6Q6MPIRT532WOTTWLP25NPNANCNFSM4HVXVKVQ>
. <
https://github.com/notifications/beacon/ACVCDE7LVI2JWW6TVK7LSADP25NPNA5CNFSM4HVXVKV2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODX2VEXQ.gif>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#9691?email_source=notifications&email_token=AEKTKKHWYDQXDRQCGDOGHATP25PM7A5CNFSM4HVXVKV2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODX2WOWY#issuecomment-502622043>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AEKTKKBUULM6HEYST2JCHKTP25PM7ANCNFSM4HVXVKVQ>
.
|
Contributor
|
Hi felix,
What about changes.t2t?
From: FelixGruetzmacher <notifications@github.com>
Sent: Monday, June 17, 2019 12:13 PM
To: nvaccess/nvda <nvda@noreply.github.com>
Cc: zstanecic <zvonimirek222@yandex.com>; Comment <comment@noreply.github.com>
Subject: Re: [nvaccess/nvda] New handy tech display models (#9691)
There are no strings in the PR to which translation is applicable.
Am Mo., 17. Juni 2019 um 12:11 Uhr schrieb zstanecic <
notifications@github.com <mailto:notifications@github.com> >:
Please see my previous comment mentioning leonards question
thx
From: Michael Curran ***@***.*** ***@***.***> >
Sent: Monday, June 17, 2019 11:55 AM
To: nvaccess/nvda ***@***.*** ***@***.***> >
Cc: Subscribed ***@***.*** ***@***.***> >
Subject: Re: [nvaccess/nvda] New handy tech display models (#9691)
I'm rather reluctant to do this as it was not completed until after
beta1 was released. I feel it sets a bit of a bad trend.
However, I'd like @feerrenrut's opinion on this.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub <
#9691?email_source=notifications <#9691?email_source=notifications&email_token=ACVCDE7SS7CZ3F7NWFKYU4LP25NPNA5CNFSM4HVXVKV2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODX2VEXQ#issuecomment-502616670> &email_token=ACVCDE7SS7CZ3F7NWFKYU4LP25NPNA5CNFSM4HVXVKV2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODX2VEXQ#issuecomment-502616670>
, or mute the thread <
https://github.com/notifications/unsubscribe-auth/ACVCDE6Q6MPIRT532WOTTWLP25NPNANCNFSM4HVXVKVQ>
. <
https://github.com/notifications/beacon/ACVCDE7LVI2JWW6TVK7LSADP25NPNA5CNFSM4HVXVKV2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODX2VEXQ.gif>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#9691?email_source=notifications <#9691?email_source=notifications&email_token=AEKTKKHWYDQXDRQCGDOGHATP25PM7A5CNFSM4HVXVKV2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODX2WOWY#issuecomment-502622043> &email_token=AEKTKKHWYDQXDRQCGDOGHATP25PM7A5CNFSM4HVXVKV2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODX2WOWY#issuecomment-502622043>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AEKTKKBUULM6HEYST2JCHKTP25PM7ANCNFSM4HVXVKVQ>
.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub <#9691?email_source=notifications&email_token=ACVCDEYPQ4N7VIH3KPPQ523P25PSBA5CNFSM4HVXVKV2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODX2WSIA#issuecomment-502622496> , or mute the thread <https://github.com/notifications/unsubscribe-auth/ACVCDE5YGUVP7B4WUJ37N53P25PSBANCNFSM4HVXVKVQ> . <https://github.com/notifications/beacon/ACVCDE6B4O7DCHGPG5W6BO3P25PSBA5CNFSM4HVXVKV2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODX2WSIA.gif>
|
Contributor
|
Hi, I echo caution about string freeze not because the PR doesn’t contain a new string, but because of NVDA release workflow. If the work was completed and reviewed two weeks ago, it could have been ready for 2019.2; however, introducing a new driver (or for that matter, new NVDA interface language) at this stage is very risky (the community went through a similar problem a few years with interface languages). Thanks.
From: FelixGruetzmacher <notifications@github.com>
Sent: Monday, June 17, 2019 3:13 AM
To: nvaccess/nvda <nvda@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Subject: Re: [nvaccess/nvda] New handy tech display models (#9691)
There are no strings in the PR to which translation is applicable.
Am Mo., 17. Juni 2019 um 12:11 Uhr schrieb zstanecic <
notifications@github.com>:
Please see my previous comment mentioning leonards question
thx
From: Michael Curran ***@***.***>
Sent: Monday, June 17, 2019 11:55 AM
To: nvaccess/nvda ***@***.***>
Cc: Subscribed ***@***.***>
Subject: Re: [nvaccess/nvda] New handy tech display models (#9691)
I'm rather reluctant to do this as it was not completed until after
beta1 was released. I feel it sets a bit of a bad trend.
However, I'd like @feerrenrut's opinion on this.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub <
#9691?email_source=notifications&email_token=ACVCDE7SS7CZ3F7NWFKYU4LP25NPNA5CNFSM4HVXVKV2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODX2VEXQ#issuecomment-502616670>
, or mute the thread <
https://github.com/notifications/unsubscribe-auth/ACVCDE6Q6MPIRT532WOTTWLP25NPNANCNFSM4HVXVKVQ>
. <
https://github.com/notifications/beacon/ACVCDE7LVI2JWW6TVK7LSADP25NPNA5CNFSM4HVXVKV2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODX2VEXQ.gif>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#9691?email_source=notifications&email_token=AEKTKKHWYDQXDRQCGDOGHATP25PM7A5CNFSM4HVXVKV2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODX2WOWY#issuecomment-502622043>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AEKTKKBUULM6HEYST2JCHKTP25PM7ANCNFSM4HVXVKVQ>
.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub <#9691?email_source=notifications&email_token=AB4AXEBCNIF4QJEIHZ6RIN3P25PR7A5CNFSM4HVXVKV2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODX2WSIA#issuecomment-502622496> , or mute the thread <https://github.com/notifications/unsubscribe-auth/AB4AXEEUCGRPDHDCIG3XAB3P25PR7ANCNFSM4HVXVKVQ> .
|
Contributor
Author
|
Rather unproblematic in that the changes in this case do not require any
user intervention. They just make stuff work that didn't work before. I'd
be unhappy seeing this sacrificed on the altar of bureaucracy. Then again,
I respect the law of the land, especially where quality assurance is
concerned.
Am Mo., 17. Juni 2019 um 12:13 Uhr schrieb zstanecic <
notifications@github.com>:
… Hi felix,
What about changes.t2t?
From: FelixGruetzmacher ***@***.***>
Sent: Monday, June 17, 2019 12:13 PM
To: nvaccess/nvda ***@***.***>
Cc: zstanecic ***@***.***>; Comment <
***@***.***>
Subject: Re: [nvaccess/nvda] New handy tech display models (#9691)
There are no strings in the PR to which translation is applicable.
Am Mo., 17. Juni 2019 um 12:11 Uhr schrieb zstanecic <
***@***.*** ***@***.***> >:
> Please see my previous comment mentioning leonards question
>
> thx
>
>
>
> From: Michael Curran ***@***.*** <mailto:
***@***.***> >
> Sent: Monday, June 17, 2019 11:55 AM
> To: nvaccess/nvda ***@***.*** <mailto:
***@***.***> >
> Cc: Subscribed ***@***.*** <mailto:
***@***.***> >
> Subject: Re: [nvaccess/nvda] New handy tech display models (#9691)
>
>
>
> I'm rather reluctant to do this as it was not completed until after
> beta1 was released. I feel it sets a bit of a bad trend.
>
> However, I'd like @feerrenrut's opinion on this.
>
>
>
>
> —
> You are receiving this because you are subscribed to this thread.
> Reply to this email directly, view it on GitHub <
> #9691?email_source=notifications <
#9691?email_source=notifications&email_token=ACVCDE7SS7CZ3F7NWFKYU4LP25NPNA5CNFSM4HVXVKV2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODX2VEXQ#issuecomment-502616670>
&email_token=ACVCDE7SS7CZ3F7NWFKYU4LP25NPNA5CNFSM4HVXVKV2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODX2VEXQ#issuecomment-502616670>
> , or mute the thread <
>
https://github.com/notifications/unsubscribe-auth/ACVCDE6Q6MPIRT532WOTTWLP25NPNANCNFSM4HVXVKVQ
>
> . <
>
https://github.com/notifications/beacon/ACVCDE7LVI2JWW6TVK7LSADP25NPNA5CNFSM4HVXVKV2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODX2VEXQ.gif
>
>
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <#9691?email_source=notifications <
#9691?email_source=notifications&email_token=AEKTKKHWYDQXDRQCGDOGHATP25PM7A5CNFSM4HVXVKV2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODX2WOWY#issuecomment-502622043>
&email_token=AEKTKKHWYDQXDRQCGDOGHATP25PM7A5CNFSM4HVXVKV2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODX2WOWY#issuecomment-502622043>,
> or mute the thread
> <
https://github.com/notifications/unsubscribe-auth/AEKTKKBUULM6HEYST2JCHKTP25PM7ANCNFSM4HVXVKVQ
>
> .
>
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub <
#9691?email_source=notifications&email_token=ACVCDEYPQ4N7VIH3KPPQ523P25PSBA5CNFSM4HVXVKV2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODX2WSIA#issuecomment-502622496>
, or mute the thread <
https://github.com/notifications/unsubscribe-auth/ACVCDE5YGUVP7B4WUJ37N53P25PSBANCNFSM4HVXVKVQ>
. <
https://github.com/notifications/beacon/ACVCDE6B4O7DCHGPG5W6BO3P25PSBA5CNFSM4HVXVKV2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODX2WSIA.gif>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#9691?email_source=notifications&email_token=AEKTKKGWKN3I2GIITZUYP3TP25PWFA5CNFSM4HVXVKV2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODX2WUZY#issuecomment-502622823>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AEKTKKGRQMTPGJ7UMI6ZFTDP25PWFANCNFSM4HVXVKVQ>
.
|
Contributor
|
Hi, how about a compromise: if Mick and Reef agree, I propose reserving 2019.2.1 for Felix’s work for release at least two weeks after release of 2019.2. Thanks.
From: FelixGruetzmacher <notifications@github.com>
Sent: Monday, June 17, 2019 3:18 AM
To: nvaccess/nvda <nvda@noreply.github.com>
Cc: Joseph Lee <joseph.lee22590@gmail.com>; Comment <comment@noreply.github.com>
Subject: Re: [nvaccess/nvda] New handy tech display models (#9691)
Rather unproblematic in that the changes in this case do not require any
user intervention. They just make stuff work that didn't work before. I'd
be unhappy seeing this sacrificed on the altar of bureaucracy. Then again,
I respect the law of the land, especially where quality assurance is
concerned.
Am Mo., 17. Juni 2019 um 12:13 Uhr schrieb zstanecic <
notifications@github.com>:
Hi felix,
What about changes.t2t?
From: FelixGruetzmacher ***@***.***>
Sent: Monday, June 17, 2019 12:13 PM
To: nvaccess/nvda ***@***.***>
Cc: zstanecic ***@***.***>; Comment <
***@***.***>
Subject: Re: [nvaccess/nvda] New handy tech display models (#9691)
There are no strings in the PR to which translation is applicable.
Am Mo., 17. Juni 2019 um 12:11 Uhr schrieb zstanecic <
***@***.*** ***@***.***> >:
> Please see my previous comment mentioning leonards question
>
> thx
>
>
>
> From: Michael Curran ***@***.*** <mailto:
***@***.***> >
> Sent: Monday, June 17, 2019 11:55 AM
> To: nvaccess/nvda ***@***.*** <mailto:
***@***.***> >
> Cc: Subscribed ***@***.*** <mailto:
***@***.***> >
> Subject: Re: [nvaccess/nvda] New handy tech display models (#9691)
>
>
>
> I'm rather reluctant to do this as it was not completed until after
> beta1 was released. I feel it sets a bit of a bad trend.
>
> However, I'd like @feerrenrut's opinion on this.
>
>
>
>
> —
> You are receiving this because you are subscribed to this thread.
> Reply to this email directly, view it on GitHub <
> #9691?email_source=notifications <
#9691?email_source=notifications&email_token=ACVCDE7SS7CZ3F7NWFKYU4LP25NPNA5CNFSM4HVXVKV2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODX2VEXQ#issuecomment-502616670>
&email_token=ACVCDE7SS7CZ3F7NWFKYU4LP25NPNA5CNFSM4HVXVKV2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODX2VEXQ#issuecomment-502616670>
> , or mute the thread <
>
https://github.com/notifications/unsubscribe-auth/ACVCDE6Q6MPIRT532WOTTWLP25NPNANCNFSM4HVXVKVQ
>
> . <
>
https://github.com/notifications/beacon/ACVCDE7LVI2JWW6TVK7LSADP25NPNA5CNFSM4HVXVKV2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODX2VEXQ.gif
>
>
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <#9691?email_source=notifications <
#9691?email_source=notifications&email_token=AEKTKKHWYDQXDRQCGDOGHATP25PM7A5CNFSM4HVXVKV2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODX2WOWY#issuecomment-502622043>
&email_token=AEKTKKHWYDQXDRQCGDOGHATP25PM7A5CNFSM4HVXVKV2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODX2WOWY#issuecomment-502622043>,
> or mute the thread
> <
https://github.com/notifications/unsubscribe-auth/AEKTKKBUULM6HEYST2JCHKTP25PM7ANCNFSM4HVXVKVQ
>
> .
>
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub <
#9691?email_source=notifications&email_token=ACVCDEYPQ4N7VIH3KPPQ523P25PSBA5CNFSM4HVXVKV2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODX2WSIA#issuecomment-502622496>
, or mute the thread <
https://github.com/notifications/unsubscribe-auth/ACVCDE5YGUVP7B4WUJ37N53P25PSBANCNFSM4HVXVKVQ>
. <
https://github.com/notifications/beacon/ACVCDE6B4O7DCHGPG5W6BO3P25PSBA5CNFSM4HVXVKV2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODX2WSIA.gif>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#9691?email_source=notifications&email_token=AEKTKKGWKN3I2GIITZUYP3TP25PWFA5CNFSM4HVXVKV2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODX2WUZY#issuecomment-502622823>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AEKTKKGRQMTPGJ7UMI6ZFTDP25PWFANCNFSM4HVXVKVQ>
.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub <#9691?email_source=notifications&email_token=AB4AXEGRAU75OV4BUF3ZMY3P25QFRA5CNFSM4HVXVKV2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODX2W65Q#issuecomment-502624118> , or mute the thread <https://github.com/notifications/unsubscribe-auth/AB4AXEDYWXSG3SMH6JGE3YTP25QFRANCNFSM4HVXVKVQ> .
|
Contributor
|
Well, i am even for for merging this if t doesn’t break anything in the new version, and that it it is thoroughly tested.
I am against the hotfix version.
With this hotfoxing we can just have a problems
We, the translators, even receive the strings for changes for the same hotfixes too late.
From: Joseph Lee <notifications@github.com>
Sent: Monday, June 17, 2019 12:22 PM
To: nvaccess/nvda <nvda@noreply.github.com>
Cc: zstanecic <zvonimirek222@yandex.com>; Comment <comment@noreply.github.com>
Subject: Re: [nvaccess/nvda] New handy tech display models (#9691)
Hi, how about a compromise: if Mick and Reef agree, I propose reserving 2019.2.1 for Felix’s work for release at least two weeks after release of 2019.2. Thanks.
From: FelixGruetzmacher <notifications@github.com <mailto:notifications@github.com> >
Sent: Monday, June 17, 2019 3:18 AM
To: nvaccess/nvda <nvda@noreply.github.com <mailto:nvda@noreply.github.com> >
Cc: Joseph Lee <joseph.lee22590@gmail.com <mailto:joseph.lee22590@gmail.com> >; Comment <comment@noreply.github.com <mailto:comment@noreply.github.com> >
Subject: Re: [nvaccess/nvda] New handy tech display models (#9691)
Rather unproblematic in that the changes in this case do not require any
user intervention. They just make stuff work that didn't work before. I'd
be unhappy seeing this sacrificed on the altar of bureaucracy. Then again,
I respect the law of the land, especially where quality assurance is
concerned.
Am Mo., 17. Juni 2019 um 12:13 Uhr schrieb zstanecic <
notifications@github.com <mailto:notifications@github.com> >:
Hi felix,
What about changes.t2t?
From: FelixGruetzmacher ***@***.*** ***@***.***> >
Sent: Monday, June 17, 2019 12:13 PM
To: nvaccess/nvda ***@***.*** ***@***.***> >
Cc: zstanecic ***@***.*** ***@***.***> >; Comment <
***@***.*** ***@***.***> >
Subject: Re: [nvaccess/nvda] New handy tech display models (#9691)
There are no strings in the PR to which translation is applicable.
Am Mo., 17. Juni 2019 um 12:11 Uhr schrieb zstanecic <
***@***.*** ***@***.***> ***@***.***> >:
> Please see my previous comment mentioning leonards question
>
> thx
>
>
>
> From: Michael Curran ***@***.*** ***@***.***%20%3cmailto:%0b> <mailto:
***@***.*** ***@***.***> > >
> Sent: Monday, June 17, 2019 11:55 AM
> To: nvaccess/nvda ***@***.*** ***@***.***%20%3cmailto:%0b> <mailto:
***@***.*** ***@***.***> > >
> Cc: Subscribed ***@***.*** ***@***.***%20%3cmailto:%0b> <mailto:
***@***.*** ***@***.***> > >
> Subject: Re: [nvaccess/nvda] New handy tech display models (#9691)
>
>
>
> I'm rather reluctant to do this as it was not completed until after
> beta1 was released. I feel it sets a bit of a bad trend.
>
> However, I'd like @feerrenrut's opinion on this.
>
>
>
>
> —
> You are receiving this because you are subscribed to this thread.
> Reply to this email directly, view it on GitHub <
> #9691?email_source=notifications <
#9691?email_source=notifications <#9691?email_source=notifications&email_token=ACVCDE7SS7CZ3F7NWFKYU4LP25NPNA5CNFSM4HVXVKV2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODX2VEXQ#issuecomment-502616670> &email_token=ACVCDE7SS7CZ3F7NWFKYU4LP25NPNA5CNFSM4HVXVKV2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODX2VEXQ#issuecomment-502616670>
&email_token=ACVCDE7SS7CZ3F7NWFKYU4LP25NPNA5CNFSM4HVXVKV2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODX2VEXQ#issuecomment-502616670>
> , or mute the thread <
>
https://github.com/notifications/unsubscribe-auth/ACVCDE6Q6MPIRT532WOTTWLP25NPNANCNFSM4HVXVKVQ
>
> . <
>
https://github.com/notifications/beacon/ACVCDE7LVI2JWW6TVK7LSADP25NPNA5CNFSM4HVXVKV2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODX2VEXQ.gif
>
>
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <#9691?email_source=notifications <#9691?email_source=notifications%20%3c%0b> <
#9691?email_source=notifications <#9691?email_source=notifications&email_token=AEKTKKHWYDQXDRQCGDOGHATP25PM7A5CNFSM4HVXVKV2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODX2WOWY#issuecomment-502622043> &email_token=AEKTKKHWYDQXDRQCGDOGHATP25PM7A5CNFSM4HVXVKV2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODX2WOWY#issuecomment-502622043>
&email_token=AEKTKKHWYDQXDRQCGDOGHATP25PM7A5CNFSM4HVXVKV2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODX2WOWY#issuecomment-502622043>,
> or mute the thread
> <
https://github.com/notifications/unsubscribe-auth/AEKTKKBUULM6HEYST2JCHKTP25PM7ANCNFSM4HVXVKVQ
>
> .
>
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub <
#9691?email_source=notifications <#9691?email_source=notifications&email_token=ACVCDEYPQ4N7VIH3KPPQ523P25PSBA5CNFSM4HVXVKV2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODX2WSIA#issuecomment-502622496> &email_token=ACVCDEYPQ4N7VIH3KPPQ523P25PSBA5CNFSM4HVXVKV2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODX2WSIA#issuecomment-502622496>
, or mute the thread <
https://github.com/notifications/unsubscribe-auth/ACVCDE5YGUVP7B4WUJ37N53P25PSBANCNFSM4HVXVKVQ>
. <
https://github.com/notifications/beacon/ACVCDE6B4O7DCHGPG5W6BO3P25PSBA5CNFSM4HVXVKV2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODX2WSIA.gif>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#9691?email_source=notifications <#9691?email_source=notifications&email_token=AEKTKKGWKN3I2GIITZUYP3TP25PWFA5CNFSM4HVXVKV2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODX2WUZY#issuecomment-502622823> &email_token=AEKTKKGWKN3I2GIITZUYP3TP25PWFA5CNFSM4HVXVKV2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODX2WUZY#issuecomment-502622823>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AEKTKKGRQMTPGJ7UMI6ZFTDP25PWFANCNFSM4HVXVKVQ>
.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub <#9691?email_source=notifications <#9691?email_source=notifications&email_token=AB4AXEGRAU75OV4BUF3ZMY3P25QFRA5CNFSM4HVXVKV2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODX2W65Q#issuecomment-502624118> &email_token=AB4AXEGRAU75OV4BUF3ZMY3P25QFRA5CNFSM4HVXVKV2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODX2W65Q#issuecomment-502624118> , or mute the thread <https://github.com/notifications/unsubscribe-auth/AB4AXEDYWXSG3SMH6JGE3YTP25QFRANCNFSM4HVXVKVQ> .
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub <#9691?email_source=notifications&email_token=ACVCDE4XM23HFCGAVUXQK2DP25QTJA5CNFSM4HVXVKV2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODX2XHEQ#issuecomment-502625170> , or mute the thread <https://github.com/notifications/unsubscribe-auth/ACVCDE2YBXOI34Z5LSOI54LP25QTJANCNFSM4HVXVKVQ> . <https://github.com/notifications/beacon/ACVCDEZMDUENYEQ3UOC5BFDP25QTJA5CNFSM4HVXVKV2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODX2XHEQ.gif>
|
Contributor
Author
|
If it won't be much more than two weeks I'd be happy with this.
Am Mo., 17. Juni 2019 um 12:21 Uhr schrieb Joseph Lee <
notifications@github.com>:
… Hi, how about a compromise: if Mick and Reef agree, I propose reserving
2019.2.1 for Felix’s work for release at least two weeks after release of
2019.2. Thanks.
From: FelixGruetzmacher ***@***.***>
Sent: Monday, June 17, 2019 3:18 AM
To: nvaccess/nvda ***@***.***>
Cc: Joseph Lee ***@***.***>; Comment <
***@***.***>
Subject: Re: [nvaccess/nvda] New handy tech display models (#9691)
Rather unproblematic in that the changes in this case do not require any
user intervention. They just make stuff work that didn't work before. I'd
be unhappy seeing this sacrificed on the altar of bureaucracy. Then again,
I respect the law of the land, especially where quality assurance is
concerned.
Am Mo., 17. Juni 2019 um 12:13 Uhr schrieb zstanecic <
***@***.***>:
> Hi felix,
>
> What about changes.t2t?
>
>
>
>
>
> From: FelixGruetzmacher ***@***.***>
> Sent: Monday, June 17, 2019 12:13 PM
> To: nvaccess/nvda ***@***.***>
> Cc: zstanecic ***@***.***>; Comment <
> ***@***.***>
> Subject: Re: [nvaccess/nvda] New handy tech display models (#9691)
>
>
>
> There are no strings in the PR to which translation is applicable.
>
> Am Mo., 17. Juni 2019 um 12:11 Uhr schrieb zstanecic <
> ***@***.*** ***@***.***> >:
>
> > Please see my previous comment mentioning leonards question
> >
> > thx
> >
> >
> >
> > From: Michael Curran ***@***.*** <mailto:
> ***@***.***> >
> > Sent: Monday, June 17, 2019 11:55 AM
> > To: nvaccess/nvda ***@***.*** <mailto:
> ***@***.***> >
> > Cc: Subscribed ***@***.*** <mailto:
> ***@***.***> >
> > Subject: Re: [nvaccess/nvda] New handy tech display models (#9691)
> >
> >
> >
> > I'm rather reluctant to do this as it was not completed until after
> > beta1 was released. I feel it sets a bit of a bad trend.
> >
> > However, I'd like @feerrenrut's opinion on this.
> >
> >
> >
> >
> > —
> > You are receiving this because you are subscribed to this thread.
> > Reply to this email directly, view it on GitHub <
> > #9691?email_source=notifications
<
>
#9691?email_source=notifications&email_token=ACVCDE7SS7CZ3F7NWFKYU4LP25NPNA5CNFSM4HVXVKV2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODX2VEXQ#issuecomment-502616670
>
>
&email_token=ACVCDE7SS7CZ3F7NWFKYU4LP25NPNA5CNFSM4HVXVKV2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODX2VEXQ#issuecomment-502616670>
> > , or mute the thread <
> >
>
https://github.com/notifications/unsubscribe-auth/ACVCDE6Q6MPIRT532WOTTWLP25NPNANCNFSM4HVXVKVQ
> >
> > . <
> >
>
https://github.com/notifications/beacon/ACVCDE7LVI2JWW6TVK7LSADP25NPNA5CNFSM4HVXVKV2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODX2VEXQ.gif
> >
> >
> >
> > —
> > You are receiving this because you were mentioned.
> > Reply to this email directly, view it on GitHub
> > <#9691?email_source=notifications
<
>
#9691?email_source=notifications&email_token=AEKTKKHWYDQXDRQCGDOGHATP25PM7A5CNFSM4HVXVKV2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODX2WOWY#issuecomment-502622043
>
>
&email_token=AEKTKKHWYDQXDRQCGDOGHATP25PM7A5CNFSM4HVXVKV2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODX2WOWY#issuecomment-502622043>,
> > or mute the thread
> > <
>
https://github.com/notifications/unsubscribe-auth/AEKTKKBUULM6HEYST2JCHKTP25PM7ANCNFSM4HVXVKVQ
> >
> > .
> >
>
>
>
> —
> You are receiving this because you commented.
> Reply to this email directly, view it on GitHub <
>
#9691?email_source=notifications&email_token=ACVCDEYPQ4N7VIH3KPPQ523P25PSBA5CNFSM4HVXVKV2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODX2WSIA#issuecomment-502622496
>
> , or mute the thread <
>
https://github.com/notifications/unsubscribe-auth/ACVCDE5YGUVP7B4WUJ37N53P25PSBANCNFSM4HVXVKVQ
>
> . <
>
https://github.com/notifications/beacon/ACVCDE6B4O7DCHGPG5W6BO3P25PSBA5CNFSM4HVXVKV2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODX2WSIA.gif
>
>
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <
#9691?email_source=notifications&email_token=AEKTKKGWKN3I2GIITZUYP3TP25PWFA5CNFSM4HVXVKV2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODX2WUZY#issuecomment-502622823
>,
> or mute the thread
> <
https://github.com/notifications/unsubscribe-auth/AEKTKKGRQMTPGJ7UMI6ZFTDP25PWFANCNFSM4HVXVKVQ
>
> .
>
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub <
#9691?email_source=notifications&email_token=AB4AXEGRAU75OV4BUF3ZMY3P25QFRA5CNFSM4HVXVKV2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODX2W65Q#issuecomment-502624118>
, or mute the thread <
https://github.com/notifications/unsubscribe-auth/AB4AXEDYWXSG3SMH6JGE3YTP25QFRANCNFSM4HVXVKVQ>
.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#9691?email_source=notifications&email_token=AEKTKKEY4KROIS7HPX6VADDP25QTTA5CNFSM4HVXVKV2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODX2XHEQ#issuecomment-502625170>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AEKTKKFOQRNWKIGGC7I3LOLP25QTTANCNFSM4HVXVKVQ>
.
|
Contributor
|
Hi, I’m thinking two weeks so that at least half of it can be devoted to an RC-style testing. Thanks.
From: FelixGruetzmacher <notifications@github.com>
Sent: Monday, June 17, 2019 3:32 AM
To: nvaccess/nvda <nvda@noreply.github.com>
Cc: Joseph Lee <joseph.lee22590@gmail.com>; Comment <comment@noreply.github.com>
Subject: Re: [nvaccess/nvda] New handy tech display models (#9691)
If it won't be much more than two weeks I'd be happy with this.
Am Mo., 17. Juni 2019 um 12:21 Uhr schrieb Joseph Lee <
notifications@github.com>:
Hi, how about a compromise: if Mick and Reef agree, I propose reserving
2019.2.1 for Felix’s work for release at least two weeks after release of
2019.2. Thanks.
From: FelixGruetzmacher ***@***.***>
Sent: Monday, June 17, 2019 3:18 AM
To: nvaccess/nvda ***@***.***>
Cc: Joseph Lee ***@***.***>; Comment <
***@***.***>
Subject: Re: [nvaccess/nvda] New handy tech display models (#9691)
Rather unproblematic in that the changes in this case do not require any
user intervention. They just make stuff work that didn't work before. I'd
be unhappy seeing this sacrificed on the altar of bureaucracy. Then again,
I respect the law of the land, especially where quality assurance is
concerned.
Am Mo., 17. Juni 2019 um 12:13 Uhr schrieb zstanecic <
***@***.***>:
> Hi felix,
>
> What about changes.t2t?
>
>
>
>
>
> From: FelixGruetzmacher ***@***.***>
> Sent: Monday, June 17, 2019 12:13 PM
> To: nvaccess/nvda ***@***.***>
> Cc: zstanecic ***@***.***>; Comment <
> ***@***.***>
> Subject: Re: [nvaccess/nvda] New handy tech display models (#9691)
>
>
>
> There are no strings in the PR to which translation is applicable.
>
> Am Mo., 17. Juni 2019 um 12:11 Uhr schrieb zstanecic <
> ***@***.*** ***@***.***> >:
>
> > Please see my previous comment mentioning leonards question
> >
> > thx
> >
> >
> >
> > From: Michael Curran ***@***.*** <mailto:
> ***@***.***> >
> > Sent: Monday, June 17, 2019 11:55 AM
> > To: nvaccess/nvda ***@***.*** <mailto:
> ***@***.***> >
> > Cc: Subscribed ***@***.*** <mailto:
> ***@***.***> >
> > Subject: Re: [nvaccess/nvda] New handy tech display models (#9691)
> >
> >
> >
> > I'm rather reluctant to do this as it was not completed until after
> > beta1 was released. I feel it sets a bit of a bad trend.
> >
> > However, I'd like @feerrenrut's opinion on this.
> >
> >
> >
> >
> > —
> > You are receiving this because you are subscribed to this thread.
> > Reply to this email directly, view it on GitHub <
> > #9691?email_source=notifications
<
>
#9691?email_source=notifications&email_token=ACVCDE7SS7CZ3F7NWFKYU4LP25NPNA5CNFSM4HVXVKV2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODX2VEXQ#issuecomment-502616670
>
>
&email_token=ACVCDE7SS7CZ3F7NWFKYU4LP25NPNA5CNFSM4HVXVKV2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODX2VEXQ#issuecomment-502616670>
> > , or mute the thread <
> >
>
https://github.com/notifications/unsubscribe-auth/ACVCDE6Q6MPIRT532WOTTWLP25NPNANCNFSM4HVXVKVQ
> >
> > . <
> >
>
https://github.com/notifications/beacon/ACVCDE7LVI2JWW6TVK7LSADP25NPNA5CNFSM4HVXVKV2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODX2VEXQ.gif
> >
> >
> >
> > —
> > You are receiving this because you were mentioned.
> > Reply to this email directly, view it on GitHub
> > <#9691?email_source=notifications
<
>
#9691?email_source=notifications&email_token=AEKTKKHWYDQXDRQCGDOGHATP25PM7A5CNFSM4HVXVKV2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODX2WOWY#issuecomment-502622043
>
>
&email_token=AEKTKKHWYDQXDRQCGDOGHATP25PM7A5CNFSM4HVXVKV2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODX2WOWY#issuecomment-502622043>,
> > or mute the thread
> > <
>
https://github.com/notifications/unsubscribe-auth/AEKTKKBUULM6HEYST2JCHKTP25PM7ANCNFSM4HVXVKVQ
> >
> > .
> >
>
>
>
> —
> You are receiving this because you commented.
> Reply to this email directly, view it on GitHub <
>
#9691?email_source=notifications&email_token=ACVCDEYPQ4N7VIH3KPPQ523P25PSBA5CNFSM4HVXVKV2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODX2WSIA#issuecomment-502622496
>
> , or mute the thread <
>
https://github.com/notifications/unsubscribe-auth/ACVCDE5YGUVP7B4WUJ37N53P25PSBANCNFSM4HVXVKVQ
>
> . <
>
https://github.com/notifications/beacon/ACVCDE6B4O7DCHGPG5W6BO3P25PSBA5CNFSM4HVXVKV2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODX2WSIA.gif
>
>
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <
#9691?email_source=notifications&email_token=AEKTKKGWKN3I2GIITZUYP3TP25PWFA5CNFSM4HVXVKV2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODX2WUZY#issuecomment-502622823
>,
> or mute the thread
> <
https://github.com/notifications/unsubscribe-auth/AEKTKKGRQMTPGJ7UMI6ZFTDP25PWFANCNFSM4HVXVKVQ
>
> .
>
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub <
#9691?email_source=notifications&email_token=AB4AXEGRAU75OV4BUF3ZMY3P25QFRA5CNFSM4HVXVKV2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODX2W65Q#issuecomment-502624118>
, or mute the thread <
https://github.com/notifications/unsubscribe-auth/AB4AXEDYWXSG3SMH6JGE3YTP25QFRANCNFSM4HVXVKVQ>
.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#9691?email_source=notifications&email_token=AEKTKKEY4KROIS7HPX6VADDP25QTTA5CNFSM4HVXVKV2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODX2XHEQ#issuecomment-502625170>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AEKTKKFOQRNWKIGGC7I3LOLP25QTTANCNFSM4HVXVKVQ>
.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub <#9691?email_source=notifications&email_token=AB4AXEAUNP6P2IRE6YCCDZLP25R3BA5CNFSM4HVXVKV2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODX2X7NI#issuecomment-502628277> , or mute the thread <https://github.com/notifications/unsubscribe-auth/AB4AXEDFNPT3LXRM6NIXOCDP25R3BANCNFSM4HVXVKVQ> .
|
Collaborator
|
An alternative could be stripping this pr back to the pure basics, i.e. adding support for basic braille plus, not for the window message handling. Then, we could do the window message handling in a new pr for 2019.3 |
Contributor
Author
|
The message handling is very important to our customers as one of our
applications does not work without it, so I'm in favor of the 2019.2.1
approach.
Am Mo., 17. Juni 2019 um 13:15 Uhr schrieb Leonard de Ruijter <
notifications@github.com>:
… An alternative could be stripping this pr back to the pure basics, i.e.
adding support for basic braille plus, not for the window message handling.
Then, we could do the window message handling in a new pr for 2019.3
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#9691?email_source=notifications&email_token=AEKTKKFE7WQP6LH5JEXHIRLP25W6PA5CNFSM4HVXVKV2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODX2272Q#issuecomment-502640618>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AEKTKKCO6TFHRXKORM23SBLP25W6PANCNFSM4HVXVKVQ>
.
|
Contributor
|
I am against stripping
From: Leonard de Ruijter <notifications@github.com>
Sent: Monday, June 17, 2019 1:16 PM
To: nvaccess/nvda <nvda@noreply.github.com>
Cc: zstanecic <zvonimirek222@yandex.com>; Comment <comment@noreply.github.com>
Subject: Re: [nvaccess/nvda] New handy tech display models (#9691)
An alternative could be stripping this pr back to the pure basics, i.e. adding support for basic braille plus, not for the window message handling. Then, we could do the window message handling in a new pr for 2019.3
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub <#9691?email_source=notifications&email_token=ACVCDEYXOWCAX6RNAC3JTVTP25W6DA5CNFSM4HVXVKV2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODX2272Q#issuecomment-502640618> , or mute the thread <https://github.com/notifications/unsubscribe-auth/ACVCDE6GAEABHVVGYIOL4T3P25W6DANCNFSM4HVXVKVQ> . <https://github.com/notifications/beacon/ACVCDE3OLMSO75ID2MG3ULDP25W6DA5CNFSM4HVXVKV2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODX2272Q.gif>
|
Member
|
Since another bug was identified in the beta which means we need to now release a beta2, I am going to review this, and if I approve it I will merge it to beta. |
michaelDCurran
approved these changes
Jun 21, 2019
Member
|
Beta2 (containing this pr) has been published. Can you please test the beta and confirm the changes in this pr are functioning correctly in the beta? |
Contributor
Author
|
Will test this with high priority as I'm surrounded by the required devices.
Am Di., 25. Juni 2019 um 08:43 Uhr schrieb Michael Curran <
notifications@github.com>:
… Beta2 (containing this pr) has been published. Can you please test the
beta and confirm the changes in this pr are functioning correctly in the
beta?
2019.2Beta2 download:
https://ci.appveyor.com/api/buildjobs/4kuwrvn7r0l2erd1/artifacts/output/nvda_2019.2beta2.exe
If everything is okay, then I will release rc1 within the next few days.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#9691?email_source=notifications&email_token=AEKTKKCELHA5PV5TFYP73LDP4G5BNA5CNFSM4HVXVKV2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYPGOTY#issuecomment-505309007>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AEKTKKCPQ52MMNNFSON4Z53P4G5BNANCNFSM4HVXVKVQ>
.
|
8 tasks
seanbudd
added a commit
that referenced
this pull request
Jul 9, 2021
When vendor-specific applications need direct access to a Handy Tech Braille display, they indicate this by sending a window message to a driver-created invisible window. #9691 introduced this window for the handy tech driver, but it had some serious issues when doing the following ensures that only one invisible driver window can be active by saving it on the class instead on instances of the class. Co-authored-by: buddsean <sean@nvaccess.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Does not apply.
Summary of the issue:
When vendor-specific applications need direct access to a Handy Tech Braille display, they indicate this by sending a window message to a driver-created invisible window. Up until now, the native NVDA driver for Handy Tech devices does not create this window.
Description of how this pull request fixes the issue:
The driver now creates the window upon instantiation. It also responds to the sleep and wake messages appropriately.
Testing performed:
Tested with Actilino by sending a file to it via HTCom while driver was running. File was successfully sent, and afterwards the driver resumed its operation normally, i.e. the device restarted to braille.
Known issues with pull request:
None known.
Change log entry:
Section: Bug fixes
Section: New features