add reportActiveConfigurationProfile command#9325
Conversation
"(self, gesture):" » "(self,gesture):" (See a few lines below) What global input gesture is used for this command? NVDA+CTRL+Shift+P would be possible. And I guess that the message output will be via speech and braille together, right? |
|
You could consider assigning shift+NVDA+p as default. |
Visually, code without spaces is harder to read. So while much of the code is formatted this way, though certainly not all, I hope we are able to start to transition.
Correct, although I have not tested with a braille display.
Given the revised approach to #9325 (not changing the title text), this command might not be so urgent. If there is demand for it, we could still consider including it. However I think we should be cautious about assigning a default gesture. |
|
@feerrenrut: Not only visually, also on a braille display. As I'm not familiar with Python, I didn't know that both methods are valid and equal. I thought it was a typo. Thanks for the explanation. |
As @DrSooom proposed in #9325 (comment) I think NVDA+control+shift+p is more relevant as it would:
Btw, I am not at all in favor of unassigned default gestures for commands that can be useful for beginners to intermediate users. |
|
The issue this PR attempted to address was resolved in the PR. However I think it could still be useful functionality, so I'll mark it as ready for review. Since sensible gestures are short supply I'd prefer to leave this unbound initially. I don't think that working with profiles is a beginner feature. |
|
@lukaszgo1 has a good point. |
This comment has been minimized.
This comment has been minimized.
|
I have addressed the changes. The core concept was already reviewed. I'm going to merge this PR. |
|
is this documented accordingly in the user guide? |
|
@Adriani90 Are all commands documented in the user guide? It's not a particularly interesting command in need of explanation, and is listed in the gestures dialog. |
|
I guess not.
I just thought about a short sentence in the profiles section, saying that it is possible to assign a gesture for reporting current profile. In my view users should be aware of this possibility. Such a sentence makes sense for all unassigned commands in coresponding sections of the user guide.
Von meinem iPhone gesendet
… Am 16.04.2020 um 13:39 schrieb Reef Turner ***@***.***>:
@Adriani90 Are all commands documented in the user guide? It's not a particularly interesting command in need of explanation, and is listed in the gestures dialog.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
|
Then we have two places to maintain the list of commands, and two places to keep translations consistent. I don't think adding something to the user guide is a good way to make a new feature discoverable, it's main purpose is to explain confusing or complicated options. The changes file was updated, its purpose is discoverability. Otherwise, for a listing of all commands users should consult the inputGestures dialog. To specifically make unassigned commands more discoverable, we should enhance the input gestures dialog with filters. |
|
@feerrenrut I agree. If there is a filter implemented, then it would help to have a cathegory which displays only the unassigned gestures for example. |
Link to issue number:
Initially developed due to #9239 (comment)
Summary of the issue:
Even though the issue of announcing the current profile was resolved in #9239 reporting the current profile name may be useful more generally.
Description of how this pull request fixes the issue:
A new command is introduced that allows the active configuration profile to be reported.
Reports "normal configuration profile active" or "{profileName} configuration profile active"
No default gesture is assigned.
Testing performed:
Checked that the correct name is reported when a configuration profile is active, and when the normal configuration is active.
Known issues with pull request:
Change log entry:
New Features
- Added a command to report the active configuration profile (#9325).