renamed Norwegian braille table to a new one as requested and adds afrikaans table#9186
Merged
Conversation
note, if the unit tests pass, this can be merged into master
LeonarddeR
suggested changes
Jan 23, 2019
LeonarddeR
left a comment
Collaborator
There was a problem hiding this comment.
I believe this is your first pr, congratulations. Please feel free to update the copyright header at the top of brailleTables.py
| "mn-MN.utb":"mn-MN-g1.utb", | ||
| "nl-BE-g1.ctb":"nl-BE-g0.utb", | ||
| "nl-NL-g1.ctb":"nl-NL-g0.utb", | ||
| "no-no.ctb":"no-no-comp8.ctb", |
Collaborator
There was a problem hiding this comment.
If you remove this line, people with an old version of NVDA upgrading to a newer version might get stuck, since no-no.ctb might not exist any more.
Please add "no-no.ctb":"no-no-comp8.itb",
fixed dictionary declarations for the norwegian table
LeonarddeR
reviewed
Jan 23, 2019
covering new braille table rename. Co-Authored-By: zstanecic <zvonimirek222@yandex.com>
LeonarddeR
approved these changes
Jan 23, 2019
This reverts commit 2da5d52.
LeonarddeR
approved these changes
Jan 23, 2019
michaelDCurran
approved these changes
Jan 28, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Closes #9170
Summary of the issue:
This pull request updates the path to the norwegian braille table from the year 2015, as requested by Lars bjorndal and adds Afrikaans braille table.
Description of how this pull request fixes the issue:
Renamed no-no-comp8.ctb to the respective counterpart and added Afrikaans braille table
Testing performed:
switched to the mentioned new braille table, and it works. I.e.
Known issues with pull request:
none
Change log entry:
Section: New features, Changes, Bug fixes
new features, changes