Fix functionality of the last 16 routing keys on 80 cell eurobraille displays#9160
Merged
Conversation
michaelDCurran
approved these changes
Jan 21, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
None
Summary of the issue:
On eurobraille displays with 80 cells, using the cursor routings of the last cursor routing keys routes the cursor to one of the first cells on the display.
Description of how this pull request fixes the issue:
There was an incorrect bitmask in the driver, 0x3f had to be 0xff. I'm really not sure why I've made this mistake in the past, since 0x3f makes no sense at all.
Testing performed:
Confirmed that all cursor routing keys on a 80 cell display work as expected.
Known issues with pull request:
None
Change log entry: