Move the message 'selected' after the text which is selected.#9028
Conversation
|
However, I think in cases when the shift key is not working properly, reporting selected at the beginning is at least a confirmation that everything worked properly. Otherwise if shift key is blocked or something like that then you get the info after the text. It is a smal Detail but though. |
|
sorry I mean if the shift key is working properly, you get the info at the end of the selection reporting. So you have to wait until the text is reported to be sure that you have selected the text. |
|
but yes, testing now in many applications it seems that if you select text with shift and arrow keys, NVDA reports "selected" after the selection. If you press nvda+shift+s (Laptop layout), NVDA reports "selected" first and then the selection. But if I understand this PR correctly you have moved the word "selected" at the end for nvda+shift+up arrow or nvda+shift+s command. Right? |
|
@Adriani90 wrote
Not only that, but also for the situations when you are selecting text. Regarding the shift key what you have written is of course true, but I believe, that we should create optimal experience for the most typical situations, and in the typical scenarios Shift is working. |
|
Erm. Is this not an old argument from several years ago about whether it can
be made configurable or not and who likes which way around. I only mention
it as I remember the discussion before the migration to github.
Brian
bglists@blueyonder.co.uk
Sent via blueyonder.
Please address personal E-mail to:-
briang1@blueyonder.co.uk, putting 'Brian Gaff'
in the display name field.
-----
|
|
@LeonarddeR wrote:
It looks like it. With this we ad least reporting text before selection consistently. |
|
Any chance for a review of this? This pr is really simple + it is very annoying to hear selected at the beginning. |
LeonarddeR
left a comment
There was a problem hiding this comment.
There is one case where selection is announced using speech.speakMessage. Could you find out why this is not using speech.speakSelectionmessage? I think there's nothing holding us back from changing that.
|
It looks like that it was done to be consistent with the announcement in case of no selection. I've changed it and testing shows that there is no problems with it. |
feerrenrut
left a comment
There was a problem hiding this comment.
Generally happy with this change, though given this is used in the same way (almost) entirely though the code base. It would be nice to remove this repetition of the "selected" string.
Perhaps something like:
speech.speakSelected(info.text)
Then we can remove repeated translator comments, and other lines missing translator comments. It also means that any future changes to this UX are more centralised. If you go down this path, don't delete the speakSelectionMessage function, but implement the new function by calling it.
There are also two calls that should continue to use "speakSelectionMesage" one says "unselected" the other "selected instead" I think these can stay as they are.
…ouncing selection. This will make future improvements to announcing selection easier.
|
@feerrenrut Done. I've also updated description accordingly. |
|
@feerrenrut This is ready for another review. |
feerrenrut
left a comment
There was a problem hiding this comment.
I'm happy with this, thanks for the contribution!
Link to issue number:
None
Summary of the issue:
When selecting text for instance in the run box, or when asking NVDA what is selected with NVDA+Shift + up arrow the first info presented was the word 'selected'' itself rather than the text which is selected. Because both selecting and reporting current selection are done to know what is selected it makes sense to present the word 'selected' at the end.
Description of how this pull request fixes the issue:
A new function speakSelectedText was added to speech.py. It is called each time when selection is announced, and word selected is placed at the end of the message.
Testing performed:
Tested in notepad, run box, kindle, Microsoft Word and Notepad++
Known issues with pull request:
None
Change log entry:
Section: Changes
NVDA will now report the word 'selected' after saying what is selected