OneCore speech: do not append silence at the end of every speech utterance#8985
Merged
Conversation
…ce at the end of each speech utterance.
josephsl
reviewed
Nov 27, 2018
josephsl
left a comment
Contributor
There was a problem hiding this comment.
Wait, if API level 7 is in use, then it'll be limited to Version 1809 (October 2018 Update) and later, whereas the PR description says fall 2017 (Fall Creators Update), which defines API level 5.
josephsl
reviewed
Nov 27, 2018
josephsl
left a comment
Contributor
There was a problem hiding this comment.
Correction: it is API level 6 (April 2018 Update), as seen from the following:
https://docs.microsoft.com/en-us/uwp/api/windows.media.speechsynthesis.speechappendedsilence
Thanks.
jcsteh
approved these changes
Nov 28, 2018
| instance->synth = ref new SpeechSynthesizer(); | ||
| // By default, OneCore speech appends a large annoying chunk of silence at the end of every utterance. | ||
| // Newer versions of OneCore speech allow disabling this feature, so turn it off where possible. | ||
| if (ApiInformation::IsApiContractPresent("Windows.Foundation.UniversalApiContract", 7, 0)) { |
Contributor
There was a problem hiding this comment.
Joseph is correct: this should be 6, not 7. I'm not sure where I got 7 from. :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
None.
Summary of the issue:
By default, OneCore speech appends a large annoying chunk of silence at the end of every speech utterance. For example, when NVDA announces a newly opened dialog, there is a large chunk of silence after announcing the dialog itself, and befor announcing the control with focus within the dialog.
Up until the Windows 10 Fall 2017 release, it was impossible to disable this feature.
As it is now possible to disable, NVDA should.
Description of how this pull request fixes the issue:
Code taken directly from #8934. If supported, this PR sets OneCore speech's appendSilence synth option to the minimum value (essentially disabling the feature).
Testing performed:
Tested NVDA using OneCore speech on Windows 10 Fall 2018: silence is no longer appended.
Known issues with pull request:
None.
Change log entry:
Bug fixes:
OneCore speech synthesizer: On Windows 10 Fall 2017 and above, large chunks of silence are no longer inserted between speech utterances.