Support the custom aria-goog-editable attribute to improve support for Google Slides #8964
Merged
Conversation
…e the editable state off in contenteditable nodes.
c6c6ba9 to
e2ef9fb
Compare
feerrenrut
approved these changes
Nov 21, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
None.
Summary of the issue:
In Google Slides, Google makes use of contenteditable for technical reasons, even when the content in question is read-only as far as the user is concerned.
This means that when moving focus around a slide, NVDA sees the focused node is editable and therefore tries to read it like it would an edit field (I.e. announces he current line of text where the caret is, or in many cases, what is selected).
Google has fixed this internally in Google Chrome by not exposing the editable state on IAccessible2 objects in this specific situation, but in Firefox, they expose a custom aria-goog-editable attribute set to False, denoting that although contenteditable is used, accessibility should reflect that it is not editable.
NVDA should honor this attribute and drop the editable state itself.
In future, this attribute could be standardized by ARIA as aria-editable.
Description of how this pull request fixes the issue:
This PR detects aria-goog-editable, and if false, discards the editable state from NVDAObjects. Thus, when moving around Google Slides, focus is announced like a normal non-editable control, rather than an edit field.
Testing performed:
Opened an existing slide dec in Google Slides. Moved focus around a slide using tab and shift+tab. Current line / selection was not announced, rather just the control itself.
Known issues with pull request:
None.
Change log entry:
Bug fixes: