Skip to content

Allow building with other Visual Studio 2017 editions (eg. Professional) #8939

@JulienCochuyt

Description

@JulienCochuyt

Steps to reproduce:

Attempt to build NVDA using Visual Studio 2017 Professional

Actual behavior:

The build fails because the file Microsoft.VC141.CRT cannot be found.
Indeed, in nvdaHelper/localWin10/sconscript, the glob Microsoft Visual Studio\2017\Community\VC\Redist\MSVC\14.1*\x86\Microsoft.VC141.CRT does not resolve to any file.

Expected behavior:

Replace the above-mentioned glob with Microsoft Visual Studio\2017\*\VC\Redist\MSVC\14.1*\x86\Microsoft.VC141.CRT, that is just replace Community with * to allow resolving to the required file when using an edition of Visual Studio different from Community.

System configuration:

NVDA Installed/portable/running from source:

Building NVDA from source

NVDA version:

Since #7568, that is version 2017.4rc1 and above, including latest master.

Windows version:

10.0.17134 Numéro 17134

Name and version of other software in use when reproducing the issue:

Visual Studio 2017 Professional version 15.6.1

Other information about your system:

Other questions:

Does the issue still occur after restarting your PC?

Yes

Have you tried any other versions of NVDA?

Yes

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions