Support IA2_ROLE_BLOCK_QUOTE.#8577
Merged
Merged
Conversation
This allows the new ARIA role="blockquote" to be supported in Firefox 63. Also, Firefox 63 exposes HTML blockquote with this role. Without this change, object navigation reports "unknown" for HTML blockquote.
michaelDCurran
previously approved these changes
Jul 31, 2018
Member
|
@jcsteh: looked good to me. but I also added support for quicknav. Annoyingly I can't ask for your review because it is your pr. |
Contributor
Author
|
Oh, I'm sorry. I should have thought of that. 🤦
|
Contributor
Author
|
For what it's worth, the quick nav change looks fine to me. |
Member
|
Merging with @jcsteh's manual approval. |
feerrenrut
reviewed
Aug 6, 2018
feerrenrut
left a comment
Contributor
There was a problem hiding this comment.
I'm a bit late, but it looks good to me!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
None.
Summary of the issue:
Description of how this pull request fixes the issue:
This PR adds support for the new IA2_ROLE_BLOCK_QUOTE, which is used by Firefox 63.
Testing performed:
data:text/html,<div role="blockquote">ARIA</div>, the presence of a block quote is reported in Firefox Nightly in both browse mode and focus mode.data:text/html,<blockquote>HTML</blockquote>, the presence of a block quote is reported in Firefox Nightly in both browse mode and focus mode.data:text/html,<blockquote>HTML</blockquote>, the presence of a block quote is reported in Chrome Canary in both browse mode and focus mode.Note that Chrome doesn't currently use this role, so the third test verifies backwards compatibility. role="blockquote" is not yet supported in Chrome, so this wasn't tested.
Known issues with pull request:
None.
Change log entry:
Section: New features
- Content marked as a block quote using ARIA (role blockquote) is now supported in Mozilla Firefox 63. (#8577)