Report deleted/inserted content in Chrome#8558
Merged
Merged
Conversation
…ssible2 roles. Adding reporting of inserted and deleted content in Chrome.
Collaborator
|
Have you considered consistency here? We now have two separate insertion/deletion implementations, one based on control field attributes (Word and UIA) and one based on roles (IA2). It would be great if we could choose one of them, but I assume that introduces othher issues?? |
LeonarddeR
reviewed
Jul 26, 2018
| @@ -486,6 +488,10 @@ | |||
| ROLE_CHARTELEMENT:_("chart element"), | |||
Collaborator
There was a problem hiding this comment.
Could you also move this one below role_audio?
Member
Author
|
Yes, there is one implementation for format fields, and one for roles /
controlFields.
Microsoft word exposes a flat view of text, where revisions are
assentially a format change. Web browsers such as Chrome expose a tree
structure, where revisions (such as insertion/deletion) are just one of
the nodes in the tree.
We could try and massage one of them into the other, but I don't think
it is worth the complication.
At the end of the day they are represented topologically very different
in each application. Abstraction can only go so far.
I suppose you *could* argue that we should change our mshtml
virtualBuffer to match Chrome... currently we are somehow faking ins/del
as formatFields. But, I'm again not sure it is worth the code chirn,
especially for an unmaintained browser.
|
|
I wonder if any of this has a knock on effect on software which uses mshtml
like some email clients still do?
Brian
|
…h annotations (a).
LeonarddeR
previously approved these changes
Jul 27, 2018
|
|
||
| if ( | ||
| role in (controlTypes.ROLE_LINK, controlTypes.ROLE_HEADING, controlTypes.ROLE_BUTTON, controlTypes.ROLE_RADIOBUTTON, controlTypes.ROLE_CHECKBOX, controlTypes.ROLE_GRAPHIC, controlTypes.ROLE_CHART, controlTypes.ROLE_MENUITEM, controlTypes.ROLE_TAB, controlTypes.ROLE_COMBOBOX, controlTypes.ROLE_SLIDER, controlTypes.ROLE_SPINBUTTON, controlTypes.ROLE_COMBOBOX, controlTypes.ROLE_PROGRESSBAR, controlTypes.ROLE_TOGGLEBUTTON, controlTypes.ROLE_MENUBUTTON, controlTypes.ROLE_TREEVIEW, controlTypes.ROLE_CHECKMENUITEM, controlTypes.ROLE_RADIOMENUITEM) | ||
| role in (controlTypes.ROLE_DELETED_CONTENT,controlTypes.ROLE_INSERTED_CONTENT,controlTypes.ROLE_LINK, controlTypes.ROLE_HEADING, controlTypes.ROLE_BUTTON, controlTypes.ROLE_RADIOBUTTON, controlTypes.ROLE_CHECKBOX, controlTypes.ROLE_GRAPHIC, controlTypes.ROLE_CHART, controlTypes.ROLE_MENUITEM, controlTypes.ROLE_TAB, controlTypes.ROLE_COMBOBOX, controlTypes.ROLE_SLIDER, controlTypes.ROLE_SPINBUTTON, controlTypes.ROLE_COMBOBOX, controlTypes.ROLE_PROGRESSBAR, controlTypes.ROLE_TOGGLEBUTTON, controlTypes.ROLE_MENUBUTTON, controlTypes.ROLE_TREEVIEW, controlTypes.ROLE_CHECKMENUITEM, controlTypes.ROLE_RADIOMENUITEM) |
Collaborator
There was a problem hiding this comment.
Could you split this into multiple lines?
LeonarddeR
approved these changes
Jul 27, 2018
Contributor
|
I'm doing this for Firefox in Mozilla bug 903187. I just tested the patch and it works as expected with NVDA, so it should be in Firefox Nightly in the next day or so (for release in Firefox 63). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
None.
Summary of the issue:
Web authors are able to mark particular content as being inserted or deleted with ins and del tags respectively.
The IAccessible2 spec has been updated to include roles for ins and del, and Chrome Canary now exposes these roles. NVDA should add its own roles for these, mapped from the IAccessible2 roles.
Description of how this pull request fixes the issue:
Testing performed:
Tested
marked text.html.txt
containing ins / del tags in Google Chrome Canary.
NVDA reports "inserted" and "deleted" for the ins and del tags respectively.
Known issues with pull request:
None.
Change log entry:
New features: