{liblouis3.6.0 brailletables}#8446
Merged
michaelDCurran merged 13 commits intoJul 17, 2018
Merged
Conversation
note, if the unit tests pass, this can be merged into master
Contributor
Contributor
Author
|
I can again say, that it is tested, and it is ready for master, as
braille tables are not breaking. appvejor assed, as i see.
|
Contributor
|
Hi, not yet, as we still want to see it incubated into next first. Thanks.
From: zstanecic <notifications@github.com>
Sent: Tuesday, June 26, 2018 3:04 PM
To: nvaccess/nvda <nvda@noreply.github.com>
Cc: Joseph Lee <joseph.lee22590@gmail.com>; Comment <comment@noreply.github.com>
Subject: Re: [nvaccess/nvda] {liblouis3.6.0 brailletables} (#8446)
I can again say, that it is tested, and it is ready for master, as
braille tables are not breaking. appvejor assed, as i see.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub <#8446 (comment)> , or mute the thread <https://github.com/notifications/unsubscribe-auth/AHgLkDkMpZVjtZUGzpBsJp9vmShk2SJOks5uAq_FgaJpZM4U4t0X> .
|
Contributor
Author
michaelDCurran
previously approved these changes
Jun 27, 2018
Contributor
Author
|
edited the change files for this PR, who can re-review it again? |
…be merged straightforward, as the only master branch is updated.
josephsl
previously approved these changes
Jul 8, 2018
josephsl
left a comment
Contributor
There was a problem hiding this comment.
If this is the same as the one approved weeks ago, then yes, I motion this be included after a second look by NV Access people. Thanks.
michaelDCurran
previously approved these changes
Jul 17, 2018
michaelDCurran
previously approved these changes
Jul 17, 2018
michaelDCurran
approved these changes
Jul 17, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
closes #8437
Summary of the issue:
In the liblouis 3.6.0, there are some new braille tables for some languages, and others, which were not added in the past.
Description of how this pull request fixes the issue:
This pull request adds new braille tables mentioned in the issue above, and corrects the russian braille table to the proper eight'dot table.
the table for russian whic was used in the past is not a proper russian eight'dot standardised table.
The table in the past was a representation for printing braille.
This pull request adds the following tables:
Testing performed:
latest master snapshot from source, on the first review, unit test passed,
Known issues with pull request:
none, can be merged to master directly
Change log entry:
=== new features ===
• added czech eight dots, central kurdish, esperanto and hungarian braille tables
=== changes===
• updated the path to the correct russian eight-dots table