UIA: assume Windows 7 is in use and remove constants that are now part of current interface#8422
Merged
Merged
Conversation
…ey. Re nvaccess#8415. UIA support in NVDA assumes Windows 7 or later. Because NVDA supports Windows 7 (SP1) and later, just assume UIA is available. However, for cases where UIA should be turned off, turn this on if UIA enabled key (from config) is on.
As NVDA supports Windows 7 (SP1) and later, there's no need to check if min Windows version is 7 anymore, thus the coresponding key in Config manager/UIA section is no longer applicable.
… with NVDA. Re nvaccess#8416. In the old days, when UIA handler supported Windows 7 and 8.x (IUIA1 through IUIA3), there were constants that were not part of the interface file that came with NVDA. now that iUIA5 is supported (and in the future, IUIA6), it makes no sense to continue to include constants that are now part of the interface itself. Thus constants included in latest UIA interface are no longer part of NVDA's own UIA handler module (not all are gone, however).
LeonarddeR
previously approved these changes
Jun 20, 2018
LeonarddeR
left a comment
Collaborator
There was a problem hiding this comment.
@michaelDCurran: could you also have a quick look?
michaelDCurran
approved these changes
Jul 18, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #8415, #8416
Summary of the issue:
UIA: assume Windows 7 is in use, remove constants that are now part of current UIA interface.
Description of how this pull request fixes the issue:
Because NVDA supports Windows 7 (SP1) and later, and since IUIA5 support is part of NVDA, do:
Testing performed:
Tested on various operating systems,. including Windows 7, Windows Server 2012 R2 (Windows 8.1), and Windows 10.
Known issues with pull request:
None
Change log entry:
Change for developers: As NVDA supports Windows 7 SP1 and later, the key "minWindowsVersion" used to check if UIA should be enabled for a particular release of Windows has been removed.