Add the Mac command key unicode character to symbols.dic.#8366
Merged
Conversation
feerrenrut
approved these changes
Jun 5, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
None.
Summary of the issue:
The Mac command key has its own unicode symbol. Some documentation, such as for Google Docs mentions both Windows and Mac shortcuts, but for the Mac shortcut uses the Mac command key symbol rather than spelling out command key. With most synthesizers, currently NVDA does not announce anything.
Description of how this pull request fixes the issue:
This PR adds the Mac Command key symbol u+2318 to symbols.dic.
Testing performed:
Read the following with NVDA: "Press Windows + l or ⌘ + space to launch the rocket!".
A real-world page with the symbol: https://www.zetetic.net/codebook/hotkeys.html
Known issues with pull request:
Technically, The unicode standard refers to this symbol as "place of interest". However, it seems that the symbol is now very widely known as the Mac command key.
Change log entry:
What's new: