Use OneCore speech on windows 10 by default rather than eSpeak#8176
Merged
Conversation
…speech by default, falling back to eSpeak if no voices are available. Previous Operating systems still use eSpeak by default.
Contributor
|
Does this only affect new installs? I don't think we should override the synth on update (in other words, if a user set their synth to Espeak/it was set as the synth due to the old default behavior, we shouldn't change to onecore on update). |
Member
Author
|
@codeofdusk this will only affect the first time you run NVDA with no existing user configuration. As soon as configuration is saved, the active synth is placed in the config it seems. |
feerrenrut
approved these changes
Apr 16, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
None
Summary of the issue:
For many years, NVDA has used eSpeak as its default voice because we could not trust the quality or existence of SAPI4 or SAPI5 voices on each machine NVDA is run on. However, as much as eSpeak is very popular with power users, it is not very well liked at all by beginners. It would greatly help the update of NVDA if we could default to a nicer sounding voice.
Description of how this pull request fixes the issue:
Windows 10 now comes with OneCore speech voices. There are mostly high quality, and most of the major languages in Windows now have speech packs meaning that the vast majority of Windows 10 machines will now come with a suitable voice included.
This PR changes the default synthesizer on windows 10 from espeak to oneCore. If for some reason the machine does not have any oneCore voices (I.e. the synthDriver fails to load, then it will still fall back to eSpeak). On previous Operating systems, the default remains as eSpeak.
Testing performed:
Ran NVDA with a new configuration on both Windows 10 and Windows 8. The Windows 10 NVDA chose oneCore, the Windows 8 NVDA chose eSpeak.
Known issues with pull request:
None.
Change log entry:
Changes:
The default speech synthesizer when running on Windows 10 is now oneCore speech rather than eSpeak.