Op 20 feb. 2018 om 07:35 heeft zstanecic ***@***.***> het volgende geschreven: Hi Braille wave with firmware 2.10 is the device with old protocol, too. Although it works with the new one, can we test old approach too? Wysłane z aplikacji Poczta dla Windows 10 Od: Leonard de Ruijter Wysłano: wtorek, 20 lutego 2018 07:23 Do: nvaccess/nvda DW: Subscribed Temat: [nvaccess/nvda] Several improvements for the handy tech driver(#8016) Link to issue number: None Description of this pull request This pr improves or extends the handy tech driver in the following way: 1. Support for the old Handy Tech protocol has been re-added. This means, support for older Modular and Braillino devices has been restored. The EasyBraille now also makes use of the older protocol, as the new protocol seemed to cause some instabilities for older firmware models here and there. 2. Support for time synchronisation. Similar to the ALVA displays, time of supported Handy Tech displays (the active line in particular) will be synchronised if out of sync more than five seconds. 3. Preparation for #7452. This is not user visible, but gives a first glance on what #7452 will be like from a implementation perspective. Most notably, atc is now a magic property on the driver. driver.atc=True enables it for supported displays, driver.atc=False disables it. For unsupported displays, only the internal state is toggled. I might change this a bit as part of #7452, as raising a NotImplementedError might be preferred instead. 4. Fixes an issue where a lot of rapid braille input on displays with a HID serial converter would lead to display connection loss. 5. Some changes to make the driver somewhat more Python 3 ready, explicitly making all strings such as constants byte strings. 6. This bundles another attempt to kill the Handy Tech COM server. Since displays for all displays has been restored, I think this can be done as part of this pr. Testing performed: Although I've not tested a Braillino myself, I've used an Easy Braille with HID serial converter for around a day without any problems or connection loss. I belief that's a setup that comes quite close to the implementation of a Braillino, although the latter might be a device with an USB serial implementation. At least, no issues did occur with the old protocol regarding input and output. Known issues with pull request: None Change log entry: • New features o Restored support for Handy Tech Braillino and Modular (with old firmware) displays. o Date and time for supported Handy Tech devices (such as Active Braille and Active Star) will now automatically be synchronized by NVDA when out of sync more than five seconds. • Bug fixes o Fixed connection stability issues for Handy Tech Easy Braille displays. You can view, comment on, or merge this pull request online at: #8016 Commit Summary • Support time synchronization and fix reconnecting for bluetooth. • Basic preparation for #7452 • Revert "Drop support for the Braillino for now" • Basic support for old protocol • More work on old protocol • Support the old protocol • cleanup • Python3 compat • Comments • Use old protocol for easy braille • Fixes • Refactor onReceive • Added support for Braillino and the old protocol • Hopefully, some changes that ease python 3 porting in future • Use old protocol for easy braille • Last refactoring, including onReceive. Old protocol input is now dstable • Remove the com server • Merge branch 'handytech-followup' of github.com:/babbagecom/nvda into handytech-followup • Review action File Changes • M miscDeps (2) • M readme.md (2) • M source/brailleDisplayDrivers/handyTech.py (398) • M source/setup.py (25) Patch Links: • https://github.com/nvaccess/nvda/pull/8016.patch • https://github.com/nvaccess/nvda/pull/8016.diff — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.