Better handle dead caret / selection text ranges in Microsoft Edge#7997
Merged
Conversation
Specifically: * No longer support remembering the last caret position for previously visited documents in Edge. This never worked and only caused errors. The UIA textRange we stored could not be used on new documents. * Detect and fix the case where the textRange we have stored as the browseMode selection dies due to major page mutations. Replace it with the first psoition in the document in this case.
feerrenrut
approved these changes
Feb 14, 2018
Collaborator
|
this could be related to #7838 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
MS bug 14251419: NVDA Desktop : MSA : We are blocked to Enter password while using NVDA Screen reader.
MS bug 15577569: NVDA announces nothing when user presses ALT + LEFT/RIGHT arrow keys.
Summary of the issue:
In many cases, the UIA textRanges we get from Microsoft Edge, may become broken or die if the page mutates a significant amount.
Two examples:
Description of how this pull request fixes the issue:
Testing performed:
Known issues with pull request:
Change log entry:
Bug fixes: