Enable liblouis multi pass (disable pass1only flag) with a hidden config parameter#7702
Merged
Conversation
…y in the braille category. This is not GUI configurable
Member
|
I think there is a typo in the python console command. One of them should be true? |
michaelDCurran
approved these changes
Oct 26, 2017
Member
|
I pushed a try build. If this succeeds, I'll incubate. |
Collaborator
Author
|
@michaelDCurran commented on 26 okt. 2017 07:03 CEST:
Yuck, fixed that. |
michaelDCurran
added a commit
that referenced
this pull request
Oct 26, 2017
This was referenced Oct 26, 2017
Collaborator
Author
|
@michaelDCurran: Is this still in your view for 2017.4? Note that this can be even merged with a new what's new entry for developers, as these are not part of the translations. |
Member
|
Sorry, I should have merged this much earlier. I'm not going to include this in 2017.4, but it is already available in Next snapshots, and I can get it into master as soon as we branch for rc (today). So there are plenty of ways people can test this out. |
This was referenced Dec 4, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Provides test possibilities for #7301
Provides a workaround for #7693
Summary of the issue:
We currently use pass1only for liblouis translation, as not providing this flag and thus using multi pass theoretically breaks input to output position mapping.
Description of how this pull request fixes the issue:
Adds outputPass1Only to the braille section of the configuration. This is not visible in the GUI. You can change this by running this from a python console
Change it back with
Testing performed:
I will provide a try build for this later today.
Known issues with pull request:
None, except it is a bit difficult to change this for non-power users.
Changes entry