added chart support for word and powerpoint in addition to excel#7046
Conversation
|
It looks like you have not committed _msOfficeChart.py |
| return _(u"{text}").format(text=text) | ||
|
|
||
| def moveTo(self): | ||
| chartNVDAObj = WordChart(windowHandle=self.document.rootNVDAObject.windowHandle, wordApplicationObject=self.rangeObj.Document.Application, wordShapeObject=self.collectionItem) |
There was a problem hiding this comment.
I think this needs to be changed to OfficeChart
…egarding error in word while processing the formula
|
Oops, I missed that file. I have also made another correction. This is regarding using formula to get text directly from the cell for xValues when formula property has series formula |
| # -*- coding: UTF-8 -*- | ||
| #NVDAObjects/window/_msOfficeChartConstants.py | ||
| #A part of NonVisual Desktop Access (NVDA) | ||
| #Copyright (C) 2014-2015 James Teh, Michael Curren, NV Access Limited |
There was a problem hiding this comment.
Fix the copyright statement. Something like Copyright (C) 2014-2017 NV access Limited, Dinesh Kaushal
|
|
||
| # Dictionary for the Description of chart types. | ||
| chartTypeDict = { | ||
| # Translators: A type of chart in Microsoft Excel. |
There was a problem hiding this comment.
Change this and all other comments to mention Microsoft Office, not Microsoft Excel specifically.
| text +=_("No Series defined.") | ||
| return text | ||
|
|
||
| def getChartSegment(self): |
There was a problem hiding this comment.
Is this different to OfficeChartElementBase.getChartSegment? if not then this can be removed.
| "kb:escape": "disablePassThrough", | ||
| } | ||
|
|
||
| class OfficeChartElement(OfficeChartElementList): |
There was a problem hiding this comment.
I find the name of this particular class confusing. I'm assuming that this element represents all the stuff that is not a series? perhaps call it OfficeChartElementMeta or something? saying OfficeChartElement makes it look too generic.
…etChartSegment and changed comments from excel to office
|
@dineshkaushal: a reminder to change the copyright line in _msOfficeChart.py to remove Michael Curran and James Teh (NV Access Limited) is enough. Also, can you merge master and fix conflicts again please. thanks :) Otherwise this is looking good. |
…tching sheets is still correctly supported. also ensure that charts are not classed as being in Excel's treeInterceptor, so that they can be dismissed properly with escape.
… must press enter on the chart to interact with it. This ensures you can still move the chart around the slide with the arrows like any other shape when not interacting.
|
I have addressed all review actions myself:
|
|
Dear all, before creating a new issue, I wanted to ask, is it possible to report if a diagram is concav or convex by signal tones? So when I navigate from value a to b and the diagram is concav, the sound should go higher and NVDA should just read the actual value. We could take the signal tones from reporting progress bars for example. |
|
Thanks Mick,
|
|
In the current implementation we are not reporting the information with tones, but that could be a good thing to try!
|
This fixes partially #1541.
This is a common implementation for office charts that works for Excel, word, and powerpoint.
Earlier implementation for excel chart #1987 worked on event based model, but this one provides keyboard navigation which is much more structured.
excelChart.py is redundent, but I have still not removed it just in case users want event based implementation back.