When disabling and then immediately re-enabling an add-on or vice versa, the add-on status now correctly reverts to what it was previously.#6299
Conversation
…sa, the add-on status now correctly reverts to what it was previously. When an add-on is in the pending disable set and the user enables it, the user is just undoing the disable; i.e. there is nothing to do. Therefore, just remove it from the pending disable set; don't also add it to the pending enable set. Make a similar change for undoing an enable.
|
STR:
|
|
@feerrenrut, can you review please? Thanks! CC @josephsl. |
|
Hi, in regards to user guide, should the possibly misleading sentence be removed? Thanks. From: James Teh [mailto:notifications@github.com] @feerrenrut https://github.com/feerrenrut , can you review please? Thanks! CC @josephsl https://github.com/josephsl . — |
|
That's a separate issue I think. See the steps to reproduce earlier in
this issue for details on what this PR is fixing.
|
|
Hi, confirmed the STR. Thanks. From: James Teh [mailto:notifications@github.com] That's a separate issue I think. See the steps to reproduce earlier in — |
|
Yep, change looks good to me. |
When an add-on is in the pending disable set and the user enables it, the user is just undoing the disable; i.e. there is nothing to do. Therefore, just remove it from the pending disable set; don't also add it to the pending enable set. Make a similar change for undoing an enable.